You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/04/12 05:32:56 UTC

[GitHub] [incubator-seatunnel] BenJFan commented on a diff in pull request #1685: [Bug][seatunnel-common]-Fix common path problem(#1683)

BenJFan commented on code in PR #1685:
URL: https://github.com/apache/incubator-seatunnel/pull/1685#discussion_r847985179


##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/config/Common.java:
##########
@@ -57,16 +58,13 @@ public static Optional<String> getDeployMode() {
     }
 
     /**
-     * Root dir varies between different spark master and deploy mode,
-     * it also varies between relative and absolute path.
-     * When running seatunnel in --master local, you can put plugins related files in $project_dir/plugins,
-     * then these files will be automatically copied to $project_dir/seatunnel-core/target and token in effect if you start seatunnel in IDE tools such as IDEA.
-     * When running seatunnel in --master yarn or --master mesos, you can put plugins related files in plugins dir.
+     * Root dir varies between different spark master and deploy mode, it also varies between relative and absolute path. When running seatunnel in --master local, you can put plugins related files in $project_dir/plugins, then these files will be automatically copied to $project_dir/seatunnel-core/target and token in effect if you start seatunnel in IDE tools such as IDEA. When running seatunnel in --master yarn or --master mesos, you can put plugins related files in plugins dir.

Review Comment:
   Single line comment should not be too long



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org