You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ki...@apache.org on 2021/06/22 22:37:16 UTC
svn commit: r1890981 -
/xmlbeans/trunk/src/main/java/org/apache/xmlbeans/impl/values/JavaBase64Holder.java
Author: kiwiwings
Date: Tue Jun 22 22:37:16 2021
New Revision: 1890981
URL: http://svn.apache.org/viewvc?rev=1890981&view=rev
Log:
XMLBEANS-481 - Base64 to byte[] is not very efficient
Modified:
xmlbeans/trunk/src/main/java/org/apache/xmlbeans/impl/values/JavaBase64Holder.java
Modified: xmlbeans/trunk/src/main/java/org/apache/xmlbeans/impl/values/JavaBase64Holder.java
URL: http://svn.apache.org/viewvc/xmlbeans/trunk/src/main/java/org/apache/xmlbeans/impl/values/JavaBase64Holder.java?rev=1890981&r1=1890980&r2=1890981&view=diff
==============================================================================
--- xmlbeans/trunk/src/main/java/org/apache/xmlbeans/impl/values/JavaBase64Holder.java (original)
+++ xmlbeans/trunk/src/main/java/org/apache/xmlbeans/impl/values/JavaBase64Holder.java Tue Jun 22 22:37:16 2021
@@ -23,7 +23,6 @@ import org.apache.xmlbeans.impl.common.Q
import org.apache.xmlbeans.impl.common.ValidationContext;
import org.apache.xmlbeans.impl.schema.BuiltinSchemaTypeSystem;
-import java.nio.charset.StandardCharsets;
import java.security.MessageDigest;
import java.security.NoSuchAlgorithmException;
import java.util.Arrays;
@@ -59,8 +58,7 @@ public abstract class JavaBase64Holder e
public static byte[] lex(String v, ValidationContext c) {
try {
- byte[] vBytes = v.getBytes(StandardCharsets.UTF_8);
- return Base64.getDecoder().decode(vBytes);
+ return Base64.getDecoder().decode(v);
} catch (IllegalArgumentException e) {
// TODO - get a decent error with line numbers and such here
c.invalid(XmlErrorCodes.BASE64BINARY, new Object[]{"not encoded properly"});
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org