[GitHub] [hive] cravani commented on a change in pull request #2710: HIVE-25605: JdbcStorageHandler Create table fails when hive.sql.schem…

[GitBox <gi...@apache.org>]

cravani commented on a change in pull request #2710:
URL: https://github.com/apache/hive/pull/2710#discussion_r725512480



##########
File path: jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/conf/JdbcStorageConfigManager.java
##########
@@ -125,9 +125,15 @@ public static String getConfigValue(JdbcStorageConfig key, Configuration config)
   public static String getOrigQueryToExecute(Configuration config) {
     String query;
     String tableName = config.get(Constants.JDBC_TABLE);
+    String schemaName = config.get(Constants.JDBC_SCHEMA);
     if (tableName != null) {
       // We generate query as select *
-      query = "select * from " + tableName;
+      if (schemaName != null) {
+        query = "select * from "+schemaName+"."+tableName;

Review comment:
       Sure




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org