You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/15 08:36:44 UTC
[GitHub] [airflow] Junnplus opened a new pull request #13690: Add hostipc and hostpid to KubernetesPodOperator
Junnplus opened a new pull request #13690:
URL: https://github.com/apache/airflow/pull/13690
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: https://github.com/apache/airflow/issues/8402
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a change in pull request #13690: Add hostipc and hostpid to KubernetesPodOperator
Posted by GitBox <gi...@apache.org>.
dstandish commented on a change in pull request #13690:
URL: https://github.com/apache/airflow/pull/13690#discussion_r570714438
##########
File path: tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py
##########
@@ -426,3 +426,40 @@ def test_node_selector(self):
client = ApiClient()
assert isinstance(result.spec.node_selector, dict)
assert client.sanitize_for_serialization(result)['spec']['nodeSelector'] == node_selector
+
+ def test_hostpid_and_hostipc(self):
Review comment:
i think it's better to parameterize a test like this. will make it easier to see exactly what you're testing, and reduce some duplication also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a change in pull request #13690: Add hostipc and hostpid to KubernetesPodOperator
Posted by GitBox <gi...@apache.org>.
dstandish commented on a change in pull request #13690:
URL: https://github.com/apache/airflow/pull/13690#discussion_r570714438
##########
File path: tests/providers/cncf/kubernetes/operators/test_kubernetes_pod.py
##########
@@ -426,3 +426,40 @@ def test_node_selector(self):
client = ApiClient()
assert isinstance(result.spec.node_selector, dict)
assert client.sanitize_for_serialization(result)['spec']['nodeSelector'] == node_selector
+
+ def test_hostpid_and_hostipc(self):
Review comment:
i think it's better to parameterize a test like this. will make it easier to see exactly what you're testing, and reduce some duplication also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Junnplus commented on pull request #13690: Add hostipc and hostpid to KubernetesPodOperator
Posted by GitBox <gi...@apache.org>.
Junnplus commented on pull request #13690:
URL: https://github.com/apache/airflow/pull/13690#issuecomment-774579477
@dstandish It seems that KubenertesExecutor is recommended to instead of KubernetesPodOperator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #13690: Add hostipc and hostpid to KubernetesPodOperator
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #13690:
URL: https://github.com/apache/airflow/pull/13690#issuecomment-774174381
> Hi. We as a community would like to significantly simplify this operator. Does this problem also occur in the new approach? I would rather not add new parameters to this operator, but encourage users to migrate.
> https://lists.apache.org/thread.html/rb1bcafea1b8f86e6d155aea7169c05805f7021e90f1636afc8019074%40%3Cdev.airflow.apache.org%3E
@mik-laj what's the new approach? I looked at thread but did not see anything replacing this operator...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13690: Add hostipc and hostpid to KubernetesPodOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13690:
URL: https://github.com/apache/airflow/pull/13690#issuecomment-762774697
Hi. We as a community would like to significantly simplify this operator. Does this problem also occur in the new approach? I would rather not add new parameters to this operator, but encourage users to migrate.
https://lists.apache.org/thread.html/rb1bcafea1b8f86e6d155aea7169c05805f7021e90f1636afc8019074%40%3Cdev.airflow.apache.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] JeffryMAC commented on pull request #13690: Add hostipc and hostpid to KubernetesPodOperator
Posted by GitBox <gi...@apache.org>.
JeffryMAC commented on pull request #13690:
URL: https://github.com/apache/airflow/pull/13690#issuecomment-762667976
Thank you @Junnplus !
@kaxil @potiuk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13690: Add hostipc and hostpid to KubernetesPodOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13690:
URL: https://github.com/apache/airflow/pull/13690#issuecomment-774580074
@dstandish it is recommended to use `pod_template_file` or `full_pod_spec` parameter. This way, you have every featture that is available on Kubernetes.
@Junnplus KubernetesPodOperator and KuberntesExecutor are different solutions and both are equally supported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Junnplus closed pull request #13690: Add hostipc and hostpid to KubernetesPodOperator
Posted by GitBox <gi...@apache.org>.
Junnplus closed pull request #13690:
URL: https://github.com/apache/airflow/pull/13690
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org