You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/11/14 21:02:40 UTC
[GitHub] ashb commented on a change in pull request #4187: [AIRFLOW-3343]
Update DockerOperator for Docker-py 3.0.0 API changes
ashb commented on a change in pull request #4187: [AIRFLOW-3343] Update DockerOperator for Docker-py 3.0.0 API changes
URL: https://github.com/apache/incubator-airflow/pull/4187#discussion_r233618445
##########
File path: airflow/operators/docker_operator.py
##########
@@ -231,8 +232,8 @@ def execute(self, context):
self.log.info(line)
exit_code = self.cli.wait(self.container['Id'])
- if exit_code != 0:
- raise AirflowException('docker container failed')
+ if exit_code['StatusCode'] != 0:
Review comment:
Good call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services