You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by GitBox <gi...@apache.org> on 2022/12/16 10:52:07 UTC
[GitHub] [age] fatimafatimaprogrammer opened a new pull request, #393: Removing Duplicate Line Of Code
fatimafatimaprogrammer opened a new pull request, #393:
URL: https://github.com/apache/age/pull/393
There was duplicate lines of code in "cypher_create.sql" file on line number 191 and 209 which i came across while exploring different files in SQL Folder.Which looks odd, so i removed those duplicate lines.
please consider to apply my little fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] MuhammadTahaNaveed commented on pull request #393: Removing Duplicate Lines Of Code
Posted by GitBox <gi...@apache.org>.
MuhammadTahaNaveed commented on PR #393:
URL: https://github.com/apache/age/pull/393#issuecomment-1356863077
Hello,
You should also update the `regress/expected/create_cypher.out` file in order to pass the failing regression tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] fatimafatimaprogrammer commented on pull request #393: Removing Duplicate Lines Of Code
Posted by GitBox <gi...@apache.org>.
fatimafatimaprogrammer commented on PR #393:
URL: https://github.com/apache/age/pull/393#issuecomment-1357841798
> Hello,
>
> You should also update the `regress/expected/create_cypher.out` file in order to pass the failing regression tests.
>
> 
Thank you for mentioning the issue Let me update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] imranzaheer612 commented on pull request #393: Removing Duplicate Lines Of Code
Posted by GitBox <gi...@apache.org>.
imranzaheer612 commented on PR #393:
URL: https://github.com/apache/age/pull/393#issuecomment-1358248906
Observe the `regression.diffs`. Try Remove the lines with `(-, !)` symbols, then run test again. Now again observe the `regression.diffs` output. It will show which lines are needed to be added (lines with symbol `+`). Add those lines. I guess it will work.
`install check` command will perform the regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] imranzaheer612 commented on pull request #393: Removing Duplicate Lines Of Code
Posted by GitBox <gi...@apache.org>.
imranzaheer612 commented on PR #393:
URL: https://github.com/apache/age/pull/393#issuecomment-1358232685
Take a look at `/regress/regression.diffs`. It will explain what changes need to be done in your expected output file. Highlighted lines with symbols `(- or !)` shows the difference that occurred during the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on pull request #393: Removing Duplicate Lines Of Code
Posted by GitBox <gi...@apache.org>.
jrgemignani commented on PR #393:
URL: https://github.com/apache/age/pull/393#issuecomment-1360418386
@fatimafatimaprogrammer @imranzaheer612 I am not sure that these are **unnecessary** duplicates. It is likely that they are purposeful done for testing the prepared statements and functions, as those are cached and run multiple times.
@JoshInnis ?
```
7ba89b01 regress/sql/cypher_create.sql (Josh Innis 2021-03-31 18:10:16 -0700 190) EXECUTE p_1;
7ba89b01 regress/sql/cypher_create.sql (Josh Innis 2021-03-31 18:10:16 -0700 191) EXECUTE p_1;
7ba89b01 regress/sql/cypher_create.sql (Josh Innis 2021-03-31 18:10:16 -0700 208) SELECT create_test();
7ba89b01 regress/sql/cypher_create.sql (Josh Innis 2021-03-31 18:10:16 -0700 209) SELECT create_test();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on pull request #393: Removing Duplicate Lines Of Code
Posted by GitBox <gi...@apache.org>.
jrgemignani commented on PR #393:
URL: https://github.com/apache/age/pull/393#issuecomment-1364261622
Then it doesn't sound like this PR is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] fatimafatimaprogrammer closed pull request #393: Removing Duplicate Lines Of Code
Posted by GitBox <gi...@apache.org>.
fatimafatimaprogrammer closed pull request #393: Removing Duplicate Lines Of Code
URL: https://github.com/apache/age/pull/393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] fatimafatimaprogrammer commented on pull request #393: Removing Duplicate Lines Of Code
Posted by GitBox <gi...@apache.org>.
fatimafatimaprogrammer commented on PR #393:
URL: https://github.com/apache/age/pull/393#issuecomment-1363907078
> @fatimafatimaprogrammer @imranzaheer612 I am not sure that these are **unnecessary** duplicates. It is likely that they are purposeful done for testing the prepared statements and functions, as those are cached and run multiple times.
>
> @JoshInnis ?
>
> ```
> 7ba89b01 regress/sql/cypher_create.sql (Josh Innis 2021-03-31 18:10:16 -0700 190) EXECUTE p_1;
> 7ba89b01 regress/sql/cypher_create.sql (Josh Innis 2021-03-31 18:10:16 -0700 191) EXECUTE p_1;
>
> 7ba89b01 regress/sql/cypher_create.sql (Josh Innis 2021-03-31 18:10:16 -0700 208) SELECT create_test();
> 7ba89b01 regress/sql/cypher_create.sql (Josh Innis 2021-03-31 18:10:16 -0700 209) SELECT create_test();
> ```
Yes after exploring and understanding further i think so too because initially i tried to fix failing test for cypher-create but by fixing that it gives failing test for graph generation file.
so I think that lines of code which seems duplicate to me initially are not actually duplicate as in cypher-create.out file it have different ids.
Thats what my understanding about this correct me if i'm wrong.
Thank you!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org