You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/02/02 11:27:48 UTC
[GitHub] [incubator-pekko] pjfanning opened a new issue, #140: fix issue with license/notice in pekko-protobuf-v3 jar
pjfanning opened a new issue, #140:
URL: https://github.com/apache/incubator-pekko/issues/140
* this jar is built using sbt-assembly and it basically shades classes from protobuf-java v3
* the existing project/MetaInfLicenseNoticeCopy.scala works for jars that we build from compiled source and resource files but does not work with sbt-assembly built jars
* sbt-assembly may have an option to add artbitrary files to the output jar but I haven't found it
* one possible solution is to build a local jar as part of the pekko build that just contains the license and notice files in its META-INF dir and let sbt-assembly merge it and the shaded contents of protobuf-java v3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on issue #140: fix issue with license/notice in pekko-protobuf-v3 jar
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #140:
URL: https://github.com/apache/incubator-pekko/issues/140#issuecomment-1423920141
So I made an issue on sbt-assembly at https://github.com/sbt/sbt-assembly/issues/491 some time ago and didn't get a response, I might try programming the solution and pinging the stakeholders.
If that doesn't end up working out (we can define a cutoff) then we can manually do the zip workaround I mentioned before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on issue #140: fix issue with license/notice in pekko-protobuf-v3 jar
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #140:
URL: https://github.com/apache/incubator-pekko/issues/140#issuecomment-1413592985
> sbt-assembly may have an option to add artbitrary files to the output jar but I haven't found it
I just had a look and also couldn't find it but I think this might be a considered a reasonable option and upstream may be open to it. Ill make an issue on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on issue #140: fix issue with license/notice in pekko-protobuf-v3 jar
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #140:
URL: https://github.com/apache/incubator-pekko/issues/140#issuecomment-1423916818
I will try and look into this on the weekend
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jrudolph closed issue #140: fix issue with license/notice in pekko-protobuf-v3 jar
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph closed issue #140: fix issue with license/notice in pekko-protobuf-v3 jar
URL: https://github.com/apache/incubator-pekko/issues/140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on issue #140: fix issue with license/notice in pekko-protobuf-v3 jar
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #140:
URL: https://github.com/apache/incubator-pekko/issues/140#issuecomment-1426684158
So I made a draft PR for sbt-assembly at https://github.com/sbt/sbt-assembly/pull/493 but @jrudolph is implying that it may not be necessary and that sbt-assembly should work with sbt's standard mechanism for resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on issue #140: fix issue with license/notice in pekko-protobuf-v3 jar
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #140:
URL: https://github.com/apache/incubator-pekko/issues/140#issuecomment-1413601251
Another option, since jar files follow the zip standard it shouldn't be too hard to just decompress the Jar file manually, add in the LICENSE/NOTICE (and any other necessary files) and then just recreate the jar. Would be a bit annoying as a workaround but it should be possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org