You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by mc...@apache.org on 2018/07/30 22:57:57 UTC
spark git commit: [SPARK-24963][K8S][TESTS] Add user-specified
service account name for client mode test driver pod
Repository: spark
Updated Branches:
refs/heads/master abbb4ab4d -> 2fbe294cf
[SPARK-24963][K8S][TESTS] Add user-specified service account name for client mode test driver pod
## What changes were proposed in this pull request?
Adds the user-set service account name for the driver pod in the client mode integration test
## How was this patch tested?
Manual test against a custom Kubernetes cluster
Author: mcheah <mc...@palantir.com>
Closes #21924 from mccheah/fix-service-account.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/2fbe294c
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/2fbe294c
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/2fbe294c
Branch: refs/heads/master
Commit: 2fbe294cf01f78b34498553d9228b57e2f992bce
Parents: abbb4ab
Author: mcheah <mc...@palantir.com>
Authored: Mon Jul 30 15:57:54 2018 -0700
Committer: mcheah <mc...@palantir.com>
Committed: Mon Jul 30 15:57:54 2018 -0700
----------------------------------------------------------------------
.../spark/deploy/k8s/integrationtest/ClientModeTestsSuite.scala | 1 +
.../deploy/k8s/integrationtest/KubernetesTestComponents.scala | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/2fbe294c/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/ClientModeTestsSuite.scala
----------------------------------------------------------------------
diff --git a/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/ClientModeTestsSuite.scala b/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/ClientModeTestsSuite.scala
index 6affee2..159cfd9 100644
--- a/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/ClientModeTestsSuite.scala
+++ b/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/ClientModeTestsSuite.scala
@@ -61,6 +61,7 @@ trait ClientModeTestsSuite { k8sSuite: KubernetesSuite =>
.withLabels(labels.asJava)
.endMetadata()
.withNewSpec()
+ .withServiceAccountName(kubernetesTestComponents.serviceAccountName)
.addNewContainer()
.withName("spark-example")
.withImage(image)
http://git-wip-us.apache.org/repos/asf/spark/blob/2fbe294c/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesTestComponents.scala
----------------------------------------------------------------------
diff --git a/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesTestComponents.scala b/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesTestComponents.scala
index a9b49a8..b602fdf 100644
--- a/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesTestComponents.scala
+++ b/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesTestComponents.scala
@@ -32,7 +32,7 @@ private[spark] class KubernetesTestComponents(defaultClient: DefaultKubernetesCl
val namespaceOption = Option(System.getProperty("spark.kubernetes.test.namespace"))
val hasUserSpecifiedNamespace = namespaceOption.isDefined
val namespace = namespaceOption.getOrElse(UUID.randomUUID().toString.replaceAll("-", ""))
- private val serviceAccountName =
+ val serviceAccountName =
Option(System.getProperty("spark.kubernetes.test.serviceAccountName"))
.getOrElse("default")
val kubernetesClient = defaultClient.inNamespace(namespace)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org