You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Satish Saley <sa...@gmail.com> on 2017/09/18 17:05:28 UTC
Review Request 62387: OOZIE-3048 Check El Functions for the
coordinator action
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62387/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-3048
https://issues.apache.org/jira/browse/OOZIE-3048
Repository: oozie-git
Description
-------
OOZIE-3048 Check El Functions for the coordinator action
Diffs
-----
core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 650e7f8c
core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 0ad39703
core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java fd2f92dc
core/src/main/java/org/apache/oozie/coord/ElException.java PRE-CREATION
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java bbe9ea7a
core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 25f250ce
core/src/test/resources/coord-action-for-invalid-elfunction.xml PRE-CREATION
core/src/test/resources/coord-job-for-invalid-elfunction.xml PRE-CREATION
Diff: https://reviews.apache.org/r/62387/diff/1/
Testing
-------
tested locally
Thanks,
Satish Saley
Re: Review Request 62387: OOZIE-3048 Check El Functions for the
coordinator action
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62387/#review185642
-----------------------------------------------------------
Ship it!
- Rohini Palaniswamy
On Sept. 19, 2017, 1 a.m., Satish Saley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62387/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2017, 1 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-3048
> https://issues.apache.org/jira/browse/OOZIE-3048
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3048 Check El Functions for the coordinator action
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 650e7f8c
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 0ad39703
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java fd2f92dc
> core/src/main/java/org/apache/oozie/coord/ElException.java PRE-CREATION
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java bbe9ea7a
> core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 25f250ce
> core/src/test/resources/coord-hcatinput-invalid-elfunction.xml PRE-CREATION
> core/src/test/resources/coord-hdfsinput-invalid-elfunction.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62387/diff/2/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Satish Saley
>
>
Re: Review Request 62387: OOZIE-3048 Check El Functions for the
coordinator action
Posted by Satish Saley <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62387/
-----------------------------------------------------------
(Updated Sept. 19, 2017, 5 p.m.)
Review request for oozie.
Bugs: OOZIE-3048
https://issues.apache.org/jira/browse/OOZIE-3048
Repository: oozie-git
Description
-------
OOZIE-3048 Check El Functions for the coordinator action
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 650e7f8c
core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 0ad39703
core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java fd2f92dc
core/src/main/java/org/apache/oozie/coord/ElException.java PRE-CREATION
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java bbe9ea7a
core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 25f250ce
core/src/test/resources/coord-hcatinput-invalid-elfunction.xml PRE-CREATION
core/src/test/resources/coord-hdfsinput-invalid-elfunction.xml PRE-CREATION
Diff: https://reviews.apache.org/r/62387/diff/3/
Changes: https://reviews.apache.org/r/62387/diff/2-3/
Testing
-------
tested locally
Thanks,
Satish Saley
Re: Review Request 62387: OOZIE-3048 Check El Functions for the
coordinator action
Posted by Satish Saley <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62387/
-----------------------------------------------------------
(Updated Sept. 18, 2017, 6 p.m.)
Review request for oozie.
Bugs: OOZIE-3048
https://issues.apache.org/jira/browse/OOZIE-3048
Repository: oozie-git
Description
-------
OOZIE-3048 Check El Functions for the coordinator action
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 650e7f8c
core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 0ad39703
core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java fd2f92dc
core/src/main/java/org/apache/oozie/coord/ElException.java PRE-CREATION
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java bbe9ea7a
core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 25f250ce
core/src/test/resources/coord-hcatinput-invalid-elfunction.xml PRE-CREATION
core/src/test/resources/coord-hdfsinput-invalid-elfunction.xml PRE-CREATION
Diff: https://reviews.apache.org/r/62387/diff/2/
Changes: https://reviews.apache.org/r/62387/diff/1-2/
Testing
-------
tested locally
Thanks,
Satish Saley
Re: Review Request 62387: OOZIE-3048 Check El Functions for the
coordinator action
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62387/#review185572
-----------------------------------------------------------
core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java
Lines 443 (patched)
<https://reviews.apache.org/r/62387/#comment261886>
Can you rename the files as coord-hcatinput-invalid-elfunction.xml and coord-hdfsinput-invalid-elfunction.xml?
- Rohini Palaniswamy
On Sept. 18, 2017, 5:05 p.m., Satish Saley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62387/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2017, 5:05 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-3048
> https://issues.apache.org/jira/browse/OOZIE-3048
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3048 Check El Functions for the coordinator action
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 650e7f8c
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 0ad39703
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java fd2f92dc
> core/src/main/java/org/apache/oozie/coord/ElException.java PRE-CREATION
> core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java bbe9ea7a
> core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java 25f250ce
> core/src/test/resources/coord-action-for-invalid-elfunction.xml PRE-CREATION
> core/src/test/resources/coord-job-for-invalid-elfunction.xml PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62387/diff/1/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Satish Saley
>
>