You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/05/28 16:36:00 UTC

[jira] [Commented] (WICKET-6555) AbstractChoice subclasses code duplication

    [ https://issues.apache.org/jira/browse/WICKET-6555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492816#comment-16492816 ] 

ASF subversion and git services commented on WICKET-6555:
---------------------------------------------------------

Commit 263fcdc65967330310df95896ca9e935bdd837f9 in wicket's branch refs/heads/WICKET-6555-choices from [~svenmeier]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=263fcdc ]

WICKET-6555 reuse code

override getDefaultChoice() return empty string


> AbstractChoice subclasses code duplication
> ------------------------------------------
>
>                 Key: WICKET-6555
>                 URL: https://issues.apache.org/jira/browse/WICKET-6555
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 8.0.0
>            Reporter: Sven Meier
>            Assignee: Sven Meier
>            Priority: Minor
>
> CheckBoxMultipleChoice and RadioChoice show a huge amount of code duplication. Furthermore with #setNullValid(true) both produce invalid markup with erroneous <option> tags.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)