[jira] [Commented] (NIFI-5188) DruidTranquilityController does not fully support Druid aggregator

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473916#comment-16473916 ] 

ASF GitHub Bot commented on NIFI-5188:
--------------------------------------

GitHub user dkhwangbo opened a pull request:

    https://github.com/apache/nifi/pull/2696

    NIFI-5188: DruidTranquilityController does not fully support Druid aggregator

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
      - I think verify this PR is enough with unit test already used.
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dkhwangbo/nifi NIFI-5188

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2696.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2696
    
----
commit b1080be5469b6e1011b560070c77201441689415
Author: Dongkyu Hwangbo <hw...@...>
Date:   2018-05-14T07:33:49Z

    NIFI-5188: DruidTranquilityController does not fully support Druid aggregator

----


> DruidTranquilityController does not fully support Druid aggregator
> ------------------------------------------------------------------
>
>                 Key: NIFI-5188
>                 URL: https://issues.apache.org/jira/browse/NIFI-5188
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.6.0
>            Reporter: Dongkyu Hwangbo
>            Priority: Major
>
> Currently DruidTranquilityController does not fully support Druid aggregator because of some code line hard-codeded in DruidTranquilityController#getAggregatorList.
> {code:java}
> ...
>             if (aggregator.get("type").equalsIgnoreCase("count")) {
>                 aggregatorList.add(getCountAggregator(aggregator));
>             } else if (aggregator.get("type").equalsIgnoreCase("doublesum")) {
>                 aggregatorList.add(getDoubleSumAggregator(aggregator));
>             } else if (aggregator.get("type").equalsIgnoreCase("doublemax")) {
>                 aggregatorList.add(getDoubleMaxAggregator(aggregator));
>             } else if (aggregator.get("type").equalsIgnoreCase("doublemin")) {
>                 aggregatorList.add(getDoubleMinAggregator(aggregator));
>             } else if (aggregator.get("type").equalsIgnoreCase("longsum")) {
>                 aggregatorList.add(getLongSumAggregator(aggregator));
>             } else if (aggregator.get("type").equalsIgnoreCase("longmax")) {
>                 aggregatorList.add(getLongMaxAggregator(aggregator));
>             } else if (aggregator.get("type").equalsIgnoreCase("longmin")) {
>                 aggregatorList.add(getLongMinAggregator(aggregator));
>             }
> ...
> {code}
> DruidTranquilityController cannot ingest other Druid aggregator not defined in above like cardinality, hyperUnique, thetaSketch and so on. Full aggregator list is in [here|http://druid.io/docs/0.9.2/querying/aggregations.html]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)