You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/08/02 02:07:08 UTC
Review Request 13207: Fixed slave to remove a queued task when the task is
terminated.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13207/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-609
https://issues.apache.org/jira/browse/MESOS-609
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/slave/slave.cpp 7f6e6b456890db438092f19a22e4dd816bb33d04
src/tests/master_tests.cpp 4c0666e30fdbf36755e6ad346adea0e26fd887f0
Diff: https://reviews.apache.org/r/13207/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13207: Fixed slave to remove a queued task when the task
is terminated.
Posted by Ben Mahler <be...@gmail.com>.
> On Aug. 2, 2013, 9:49 p.m., Ben Mahler wrote:
> > src/tests/master_tests.cpp, line 812
> > <https://reviews.apache.org/r/13207/diff/1/?file=333711#file333711line812>
> >
> > 2 line indent?
s/line/space/
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13207/#review24581
-----------------------------------------------------------
On Aug. 2, 2013, 12:07 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13207/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 12:07 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-609
> https://issues.apache.org/jira/browse/MESOS-609
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 7f6e6b456890db438092f19a22e4dd816bb33d04
> src/tests/master_tests.cpp 4c0666e30fdbf36755e6ad346adea0e26fd887f0
>
> Diff: https://reviews.apache.org/r/13207/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13207: Fixed slave to remove a queued task when the task
is terminated.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13207/#review24581
-----------------------------------------------------------
Ship it!
src/tests/master_tests.cpp
<https://reviews.apache.org/r/13207/#comment48602>
2 line indent?
- Ben Mahler
On Aug. 2, 2013, 12:07 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13207/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 12:07 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-609
> https://issues.apache.org/jira/browse/MESOS-609
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 7f6e6b456890db438092f19a22e4dd816bb33d04
> src/tests/master_tests.cpp 4c0666e30fdbf36755e6ad346adea0e26fd887f0
>
> Diff: https://reviews.apache.org/r/13207/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13207: Fixed slave to remove a queued task when the task
is terminated.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13207/#review24506
-----------------------------------------------------------
Ship it!
src/tests/master_tests.cpp
<https://reviews.apache.org/r/13207/#comment48444>
s/registerExecutor/registerExecutorMessage/?
- Benjamin Hindman
On Aug. 2, 2013, 12:07 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13207/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 12:07 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-609
> https://issues.apache.org/jira/browse/MESOS-609
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 7f6e6b456890db438092f19a22e4dd816bb33d04
> src/tests/master_tests.cpp 4c0666e30fdbf36755e6ad346adea0e26fd887f0
>
> Diff: https://reviews.apache.org/r/13207/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13207: Fixed slave to remove a queued task when the task
is terminated.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13207/
-----------------------------------------------------------
(Updated Aug. 3, 2013, 8:30 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased and bens'. nnfr.
Bugs: MESOS-609
https://issues.apache.org/jira/browse/MESOS-609
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/slave/slave.cpp 7f6e6b456890db438092f19a22e4dd816bb33d04
src/tests/master_tests.cpp 4c0666e30fdbf36755e6ad346adea0e26fd887f0
Diff: https://reviews.apache.org/r/13207/diff/
Testing
-------
make check
Thanks,
Vinod Kone