You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/04/01 03:06:00 UTC
[jira] [Commented] (IMPALA-9584) test_analytic_fns is flaky (small
fractional differences in AVG)
[ https://issues.apache.org/jira/browse/IMPALA-9584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072338#comment-17072338 ]
ASF subversion and git services commented on IMPALA-9584:
---------------------------------------------------------
Commit a08cd7f49bb9c69b05fabe9ccd18577cfd300b4e in impala's branch refs/heads/master from Csaba Ringhofer
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=a08cd7f ]
IMPALA-9584: remove flaky avg(TIMESTAMP) aggregates from test_analytic_fns
AVG(TIMESTAMP) is not deterministic, because it uses a double to sum
the timestamps, and adding doubles in different order can lead to
different results. This does not cause problems for DOUBLE columns,
because the test framework does not require exact match if the result
is double. As AVG is the only function for TIMESTAMP with this problem,
reducing the precision of all timestamps checks seemed like an
overkill.
As a short term solution I removed the problematic aggregates from the
tests.
Testing:
- ran only the related tests
Change-Id: I10e0027a64a4e430b7db3ed7c8d0cc8cdcb202e0
Reviewed-on: http://gerrit.cloudera.org:8080/15621
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> test_analytic_fns is flaky (small fractional differences in AVG)
> ----------------------------------------------------------------
>
> Key: IMPALA-9584
> URL: https://issues.apache.org/jira/browse/IMPALA-9584
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Reporter: Csaba Ringhofer
> Assignee: Csaba Ringhofer
> Priority: Blocker
> Labels: broken-build, flaky-test
>
> The issue occurred here:
> https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/2065/testReport/query_test.test_queries/TestQueries/test_analytic_fns_protocol__hs2___exec_option____batch_size___0___num_nodes___0___disable_codegen_rows_threshold___0___disable_codegen___False___abort_on_error___1___exec_single_node_rows_threshold___0____table_format__parquet_none_/
> The same test failed with all protocols.
> Failing query:
> https://github.com/apache/impala/blob/ebbe52b4bed944d3012e3679dc984827ce11d5a8/testdata/workloads/functional-query/queries/QueryTest/analytic-fns.test#L2
> Errors are like (hs2):
> 2009,3,6,3.666666666666667,2009-03-01 20:12:00.475000,'0','8' != 2009,3,6,3.66666666667,2009-03-01 20:12:00.474999,'0','8'
> I think that the problem is not the difference in the 4th double column, as that depends on the client used and we do not require complete match during comparison. So the problem is likely to be the timestamp in the 5th column.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org