You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/03/11 18:43:43 UTC
[kudu-CR] [build] Fail the LINT build with Java static analysis issues
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15409
Change subject: [build] Fail the LINT build with Java static analysis issues
......................................................................
[build] Fail the LINT build with Java static analysis issues
This patch changes the Gradle build to fail when static analysis
issues are found. In the past warnings would be logged and reports
were created, but the build would still succeed.
A `-PignoreCheckFailures` was added in case users wanted to
manually revert back to the old behavior.
Additionally the LINT Jenkins build was updated to run the
static analysis checks and fail if any are found.
Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
---
M build-support/jenkins/build-and-test.sh
M java/gradle/quality.gradle
2 files changed, 25 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/15409/1
--
To view, visit http://gerrit.cloudera.org:8080/15409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
Gerrit-Change-Number: 15409
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [build] Fail the LINT build with Java static analysis issues
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15409
to look at the new patch set (#4).
Change subject: [build] Fail the LINT build with Java static analysis issues
......................................................................
[build] Fail the LINT build with Java static analysis issues
This patch changes the Gradle build to fail when static analysis
issues are found. In the past warnings would be logged and reports
were created, but the build would still succeed.
A `-PignoreCheckFailures` was added in case users wanted to
manually revert back to the old behavior.
Additionally the LINT Jenkins build was updated to run the
static analysis checks and fail if any are found.
Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
---
M build-support/jenkins/build-and-test.sh
M java/gradle/quality.gradle
2 files changed, 39 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/15409/4
--
To view, visit http://gerrit.cloudera.org:8080/15409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
Gerrit-Change-Number: 15409
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Fail the LINT build with Java static analysis issues
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15409 )
Change subject: [build] Fail the LINT build with Java static analysis issues
......................................................................
[build] Fail the LINT build with Java static analysis issues
This patch changes the Gradle build to fail when static analysis
issues are found. In the past warnings would be logged and reports
were created, but the build would still succeed.
A `-PignoreCheckFailures` was added in case users wanted to
manually revert back to the old behavior.
Additionally the LINT Jenkins build was updated to run the
static analysis checks and fail if any are found.
Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
Reviewed-on: http://gerrit.cloudera.org:8080/15409
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M build-support/jenkins/build-and-test.sh
M java/gradle/quality.gradle
2 files changed, 45 insertions(+), 8 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
Alexey Serbin: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/15409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
Gerrit-Change-Number: 15409
Gerrit-PatchSet: 8
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Fail the LINT build with Java static analysis issues
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15409 )
Change subject: [build] Fail the LINT build with Java static analysis issues
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15409/4/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
http://gerrit.cloudera.org:8080/#/c/15409/4/build-support/jenkins/build-and-test.sh@366
PS4, Line 366: pushd $SOURCE_ROOT/java
: if ! ./gradlew $EXTRA_GRADLE_FLAGS clean check -x test $EXTRA_GRADLE_TEST_FLAGS; then
: LINT_RESULT=1
: LINT_FAILURES="$LINT_FAILURES"$'Java Gradle check failed\n'
: fi
: popd
> Should this also respect BUILD_JAVA? Why or why not?
Good question. Do you know where or how that flag is used today?
On one hand you could ignore it given we don't want "bad code" to be allowed. On the other you could respect it if users intend it to mean no-java at all.
However, no java at all doesn't really exist anymore given the hms plugin and subprocess are both Java that is built in the C++ build.
I think it's that last reason that makes me think this should not respect BUILD_JAVA. to ensure bad code isn't making its way into the C++ build too.
--
To view, visit http://gerrit.cloudera.org:8080/15409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
Gerrit-Change-Number: 15409
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Mar 2020 20:20:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Fail the LINT build with Java static analysis issues
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [build] Fail the LINT build with Java static analysis issues
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
Gerrit-Change-Number: 15409
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Fail the LINT build with Java static analysis issues
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15409
to look at the new patch set (#2).
Change subject: [build] Fail the LINT build with Java static analysis issues
......................................................................
[build] Fail the LINT build with Java static analysis issues
This patch changes the Gradle build to fail when static analysis
issues are found. In the past warnings would be logged and reports
were created, but the build would still succeed.
A `-PignoreCheckFailures` was added in case users wanted to
manually revert back to the old behavior.
Additionally the LINT Jenkins build was updated to run the
static analysis checks and fail if any are found.
Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
---
M build-support/jenkins/build-and-test.sh
M java/gradle/quality.gradle
2 files changed, 27 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/15409/2
--
To view, visit http://gerrit.cloudera.org:8080/15409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
Gerrit-Change-Number: 15409
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Fail the LINT build with Java static analysis issues
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15409 )
Change subject: [build] Fail the LINT build with Java static analysis issues
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/15409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
Gerrit-Change-Number: 15409
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 12 Mar 2020 23:46:31 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Fail the LINT build with Java static analysis issues
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15409 )
Change subject: [build] Fail the LINT build with Java static analysis issues
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15409/2/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
http://gerrit.cloudera.org:8080/#/c/15409/2/build-support/jenkins/build-and-test.sh@280
PS2, Line 280: JAVA8_HOME
What if JAVA8_HOME is not defined at all (e.g., the build machine has only JDK11)? Maybe, add a check for non-empty value and bail if the check failed?
--
To view, visit http://gerrit.cloudera.org:8080/15409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
Gerrit-Change-Number: 15409
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Mar 2020 18:53:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Fail the LINT build with Java static analysis issues
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15409 )
Change subject: [build] Fail the LINT build with Java static analysis issues
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15409/4/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
http://gerrit.cloudera.org:8080/#/c/15409/4/build-support/jenkins/build-and-test.sh@366
PS4, Line 366: pushd $SOURCE_ROOT/java
: if ! ./gradlew $EXTRA_GRADLE_FLAGS clean check -x test $EXTRA_GRADLE_TEST_FLAGS; then
: LINT_RESULT=1
: LINT_FAILURES="$LINT_FAILURES"$'Java Gradle check failed\n'
: fi
: popd
> Good question. Do you know where or how that flag is used today?
Yeah, BUILD_JAVA is definitely from before the HMS plugin landed, and hasn't been reevaluated since then.
We could continue to honor it, but we'd need to plumb it into cmake and have cmake exclude HMS/subprocess building and testing if set. Or we could go the other direction and strip it out completely. Or change it into more of a "TEST_JAVA" thing.
I'd be inclined to do the first option: I think it's useful to be able to run build-and-test.sh without having the JDK set up, or without having Python properly set up. Obviously that's more scope than what you have here, so perhaps let's leave it as:
1. Condition this new stuff on BUILD_JAVA.
2. Make a note at the BUILD_JAVA definition documenting this shortcoming.
--
To view, visit http://gerrit.cloudera.org:8080/15409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
Gerrit-Change-Number: 15409
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Mar 2020 22:31:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Fail the LINT build with Java static analysis issues
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15409 )
Change subject: [build] Fail the LINT build with Java static analysis issues
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15409/2/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
http://gerrit.cloudera.org:8080/#/c/15409/2/build-support/jenkins/build-and-test.sh@280
PS2, Line 280: JAVA8_HOME
> What if JAVA8_HOME is not defined at all (e.g., the build machine has only
This isn't a new piece of logic, I just moved it up since it should probably be defined higher in this script.
--
To view, visit http://gerrit.cloudera.org:8080/15409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
Gerrit-Change-Number: 15409
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Mar 2020 18:54:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Fail the LINT build with Java static analysis issues
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15409 )
Change subject: [build] Fail the LINT build with Java static analysis issues
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
Gerrit-Change-Number: 15409
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 12 Mar 2020 23:43:59 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Fail the LINT build with Java static analysis issues
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15409 )
Change subject: [build] Fail the LINT build with Java static analysis issues
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
Gerrit-Change-Number: 15409
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Mar 2020 21:13:36 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Fail the LINT build with Java static analysis issues
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15409
to look at the new patch set (#7).
Change subject: [build] Fail the LINT build with Java static analysis issues
......................................................................
[build] Fail the LINT build with Java static analysis issues
This patch changes the Gradle build to fail when static analysis
issues are found. In the past warnings would be logged and reports
were created, but the build would still succeed.
A `-PignoreCheckFailures` was added in case users wanted to
manually revert back to the old behavior.
Additionally the LINT Jenkins build was updated to run the
static analysis checks and fail if any are found.
Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
---
M build-support/jenkins/build-and-test.sh
M java/gradle/quality.gradle
2 files changed, 45 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/15409/7
--
To view, visit http://gerrit.cloudera.org:8080/15409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
Gerrit-Change-Number: 15409
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Fail the LINT build with Java static analysis issues
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15409 )
Change subject: [build] Fail the LINT build with Java static analysis issues
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15409/4/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
http://gerrit.cloudera.org:8080/#/c/15409/4/build-support/jenkins/build-and-test.sh@366
PS4, Line 366: pushd $SOURCE_ROOT/java
: if ! ./gradlew $EXTRA_GRADLE_FLAGS clean check -x test $EXTRA_GRADLE_TEST_FLAGS; then
: LINT_RESULT=1
: LINT_FAILURES="$LINT_FAILURES"$'Java Gradle check failed\n'
: fi
: popd
Should this also respect BUILD_JAVA? Why or why not?
--
To view, visit http://gerrit.cloudera.org:8080/15409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
Gerrit-Change-Number: 15409
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Mar 2020 20:12:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Fail the LINT build with Java static analysis issues
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15409
to look at the new patch set (#3).
Change subject: [build] Fail the LINT build with Java static analysis issues
......................................................................
[build] Fail the LINT build with Java static analysis issues
This patch changes the Gradle build to fail when static analysis
issues are found. In the past warnings would be logged and reports
were created, but the build would still succeed.
A `-PignoreCheckFailures` was added in case users wanted to
manually revert back to the old behavior.
Additionally the LINT Jenkins build was updated to run the
static analysis checks and fail if any are found.
Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
---
M build-support/jenkins/build-and-test.sh
M java/gradle/quality.gradle
2 files changed, 39 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/15409/3
--
To view, visit http://gerrit.cloudera.org:8080/15409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
Gerrit-Change-Number: 15409
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Fail the LINT build with Java static analysis issues
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15409 )
Change subject: [build] Fail the LINT build with Java static analysis issues
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15409/4/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
http://gerrit.cloudera.org:8080/#/c/15409/4/build-support/jenkins/build-and-test.sh@366
PS4, Line 366: pushd $SOURCE_ROOT/java
: if ! ./gradlew $EXTRA_GRADLE_FLAGS clean check -x test $EXTRA_GRADLE_TEST_FLAGS; then
: LINT_RESULT=1
: LINT_FAILURES="$LINT_FAILURES"$'Java Gradle check failed\n'
: fi
: popd
> Yeah, BUILD_JAVA is definitely from before the HMS plugin landed, and hasn'
Done
--
To view, visit http://gerrit.cloudera.org:8080/15409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fb8494639b1bbf9be6d2bd214a986b101496525
Gerrit-Change-Number: 15409
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 12 Mar 2020 02:01:01 +0000
Gerrit-HasComments: Yes