[superset] branch master updated: fix(explore): filter popover opening after removing a filter (#16024)

[kg...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

kgabryje pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 5917407  fix(explore): filter popover opening after removing a filter (#16024)
5917407 is described below

commit 5917407b9c39ca70da14bec76abe766c7fd62440
Author: Kamil Gabryjelski <ka...@gmail.com>
AuthorDate: Mon Aug 2 22:01:17 2021 +0200

    fix(explore): filter popover opening after removing a filter (#16024)
---
 .../components/controls/DndColumnSelectControl/Option.tsx     | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/Option.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/Option.tsx
index 824a658..3c7ee3c 100644
--- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/Option.tsx
+++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/Option.tsx
@@ -41,10 +41,13 @@ export default function Option({
   canDelete = true,
 }: OptionProps) {
   const theme = useTheme();
-  const onClickClose = useCallback(() => clickClose(index), [
-    clickClose,
-    index,
-  ]);
+  const onClickClose = useCallback(
+    e => {
+      e.stopPropagation();
+      clickClose(index);
+    },
+    [clickClose, index],
+  );
   return (
     <OptionControlContainer data-test="option-label" withCaret={withCaret}>
       {canDelete && (