You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/20 10:59:54 UTC

[GitHub] [skywalking] tuohai666 opened a new pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario. 

tuohai666 opened a new pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario. 
URL: https://github.com/apache/skywalking/pull/4093
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [x] New feature provided
   - [ ] Improve performance
   
   - Related issues
   https://github.com/apache/skywalking/issues/3583
   ___
   ### Bug fix
   - Bug description.
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 merged pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario.

Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario. 
URL: https://github.com/apache/skywalking/pull/4093
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario.

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario. 
URL: https://github.com/apache/skywalking/pull/4093#discussion_r360348246
 
 

 ##########
 File path: .github/workflows/plugins-test.yaml
 ##########
 @@ -504,3 +504,28 @@ jobs:
         run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
       - name: Run mysql 5.1.2-8.0.15 (53)
         run: bash test/plugin/run.sh mysql-scenario
+
+  ShardingSphere3x:
+    runs-on: ubuntu-18.04
+    timeout-minutes: 90
+    strategy:
+      fail-fast: true
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          submodules: true
+      - uses: actions/cache@v1
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
+      - uses: actions/setup-java@v1
+        with:
+          java-version: 8
+      - name: Build SkyWalking Agent
+        run: ./mvnw clean package -DskipTests -Pagent >/dev/null
+      - name: Build the Docker image
+        run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
+      - name: Run shardingsphere-3.x-scenario 3.0.0 (1)
+        run: bash test/plugin/run.sh shardingsphere-3.x-scenario
 
 Review comment:
   @tuohai666 more specifically, `Oracle_Kafka_JdkHttp_JdkThreading` is the fastest group now, moving to this group should be fine

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] tuohai666 commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario.

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario. 
URL: https://github.com/apache/skywalking/pull/4093#discussion_r360352817
 
 

 ##########
 File path: .github/workflows/plugins-test.yaml
 ##########
 @@ -504,3 +504,28 @@ jobs:
         run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
       - name: Run mysql 5.1.2-8.0.15 (53)
         run: bash test/plugin/run.sh mysql-scenario
+
+  ShardingSphere3x:
+    runs-on: ubuntu-18.04
+    timeout-minutes: 90
+    strategy:
+      fail-fast: true
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          submodules: true
+      - uses: actions/cache@v1
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
+      - uses: actions/setup-java@v1
+        with:
+          java-version: 8
+      - name: Build SkyWalking Agent
+        run: ./mvnw clean package -DskipTests -Pagent >/dev/null
+      - name: Build the Docker image
+        run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
+      - name: Run shardingsphere-3.x-scenario 3.0.0 (1)
+        run: bash test/plugin/run.sh shardingsphere-3.x-scenario
 
 Review comment:
   Thanks for your  comments. Can you tell me what is the fastest gropu? I can find this key word in doc, but not quite understand:
   
   Please check the prev agent related PRs, and add your case to the fastest group, in order to make the whole test finished as soon as possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] tuohai666 commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario.

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario. 
URL: https://github.com/apache/skywalking/pull/4093#discussion_r360375251
 
 

 ##########
 File path: .github/workflows/plugins-test.yaml
 ##########
 @@ -318,6 +318,8 @@ jobs:
         run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
       - name: Run redisson 3.x (37)
         run: bash test/plugin/run.sh redisson-scenario
+      - name: Run shardingsphere-3.x-scenario 3.0.0 (1)
 
 Review comment:
   Get it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4093: [test/plugin] immigrate test shardingsphere 3.x scenario.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4093: [test/plugin] immigrate test shardingsphere 3.x scenario. 
URL: https://github.com/apache/skywalking/pull/4093#issuecomment-567897546
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=h1) Report
   > Merging [#4093](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/2133669b142680668152d69d7b6a07a01c3e98a7?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4093/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4093      +/-   ##
   ==========================================
   - Coverage    27.3%   27.28%   -0.02%     
   ==========================================
     Files        1140     1140              
     Lines       25024    25024              
     Branches     3618     3618              
   ==========================================
   - Hits         6833     6828       -5     
   - Misses      17585    17591       +6     
   + Partials      606      605       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4093/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
   | [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4093/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `60.36% <0%> (-0.91%)` | :arrow_down: |
   | [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4093/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `80.32% <0%> (+3.27%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=footer). Last update [2133669...54ed712](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario.

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario. 
URL: https://github.com/apache/skywalking/pull/4093#discussion_r360354073
 
 

 ##########
 File path: .github/workflows/plugins-test.yaml
 ##########
 @@ -504,3 +504,28 @@ jobs:
         run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
       - name: Run mysql 5.1.2-8.0.15 (53)
         run: bash test/plugin/run.sh mysql-scenario
+
+  ShardingSphere3x:
+    runs-on: ubuntu-18.04
+    timeout-minutes: 90
+    strategy:
+      fail-fast: true
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          submodules: true
+      - uses: actions/cache@v1
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
+      - uses: actions/setup-java@v1
+        with:
+          java-version: 8
+      - name: Build SkyWalking Agent
+        run: ./mvnw clean package -DskipTests -Pagent >/dev/null
+      - name: Build the Docker image
+        run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
+      - name: Run shardingsphere-3.x-scenario 3.0.0 (1)
+        run: bash test/plugin/run.sh shardingsphere-3.x-scenario
 
 Review comment:
   > Thanks for your comments. Can you tell me what is the fastest gropu? I can find this key word in doc, but not quite understand:
   > 
   > Please check the prev agent related PRs, and add your case to the fastest group, in order to make the whole test finished as soon as possible.
   
   You can find the time costs for each group in the check statuses in this page, see attached picture:
   
   <img width="700" alt="image" src="https://user-images.githubusercontent.com/15965696/71255076-e5123200-2367-11ea-8941-a4128d92dfb5.png">
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io commented on issue #4093: [test/plugin] immigrate test shardingsphere 3.x scenario.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4093: [test/plugin] immigrate test shardingsphere 3.x scenario. 
URL: https://github.com/apache/skywalking/pull/4093#issuecomment-567897546
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=h1) Report
   > Merging [#4093](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/2133669b142680668152d69d7b6a07a01c3e98a7?src=pr&el=desc) will **decrease** coverage by `0.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4093/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4093      +/-   ##
   ==========================================
   - Coverage    27.3%   27.22%   -0.09%     
   ==========================================
     Files        1140     1140              
     Lines       25024    25024              
     Branches     3618     3618              
   ==========================================
   - Hits         6833     6812      -21     
   - Misses      17585    17609      +24     
   + Partials      606      603       -3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4093/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
   | [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4093/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `31.46% <0%> (-13.49%)` | :arrow_down: |
   | [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4093/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `73.77% <0%> (-3.28%)` | :arrow_down: |
   | [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4093/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `60.36% <0%> (-0.91%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=footer). Last update [2133669...54ed712](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] dmsolr commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario.

Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario. 
URL: https://github.com/apache/skywalking/pull/4093#discussion_r360343832
 
 

 ##########
 File path: test/plugin/scenarios/shardingsphere-3.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/shardingsphere/service/api/service/CommonServiceImpl.java
 ##########
 @@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.testcase.shardingsphere.service.api.service;
+
+import org.apache.skywalking.apm.testcase.shardingsphere.service.api.entity.Order;
+import org.apache.skywalking.apm.testcase.shardingsphere.service.api.entity.OrderItem;
+import org.apache.skywalking.apm.testcase.shardingsphere.service.api.repository.OrderItemRepository;
+import org.apache.skywalking.apm.testcase.shardingsphere.service.api.repository.OrderRepository;
+import java.util.ArrayList;
+import java.util.List;
+
+public abstract class CommonServiceImpl implements CommonService {
+    
+    @Override
+    public void initEnvironment() {
+        getOrderRepository().createTableIfNotExists();
+        getOrderItemRepository().createTableIfNotExists();
+        getOrderRepository().truncateTable();
+        getOrderItemRepository().truncateTable();
+        insertData();
+    }
+    
+    @Override
+    public void cleanEnvironment() {
+        getOrderRepository().dropTable();
+        getOrderItemRepository().dropTable();
+    }
+    
+    @Override
+    public void processSuccess(final boolean isRangeSharding) {
+        System.out.println("-------------- Process Success Begin ---------------");
+        printData(isRangeSharding);
+        System.out.println("-------------- Process Success Finish --------------");
 
 Review comment:
   We don't need those. Test-framework does not get `SystemOut` log, so those are unuseful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] tuohai666 commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario.

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario. 
URL: https://github.com/apache/skywalking/pull/4093#discussion_r360355241
 
 

 ##########
 File path: .github/workflows/plugins-test.yaml
 ##########
 @@ -504,3 +504,28 @@ jobs:
         run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
       - name: Run mysql 5.1.2-8.0.15 (53)
         run: bash test/plugin/run.sh mysql-scenario
+
+  ShardingSphere3x:
+    runs-on: ubuntu-18.04
+    timeout-minutes: 90
+    strategy:
+      fail-fast: true
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          submodules: true
+      - uses: actions/cache@v1
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
+      - uses: actions/setup-java@v1
+        with:
+          java-version: 8
+      - name: Build SkyWalking Agent
+        run: ./mvnw clean package -DskipTests -Pagent >/dev/null
+      - name: Build the Docker image
+        run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
+      - name: Run shardingsphere-3.x-scenario 3.0.0 (1)
+        run: bash test/plugin/run.sh shardingsphere-3.x-scenario
 
 Review comment:
   Thanks for your quick response. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4093: [test/plugin] immigrate test shardingsphere 3.x scenario.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4093: [test/plugin] immigrate test shardingsphere 3.x scenario. 
URL: https://github.com/apache/skywalking/pull/4093#issuecomment-567897546
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=h1) Report
   > Merging [#4093](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/2133669b142680668152d69d7b6a07a01c3e98a7?src=pr&el=desc) will **decrease** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4093/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4093      +/-   ##
   ==========================================
   - Coverage   27.31%   27.27%   -0.04%     
   ==========================================
     Files        1140     1140              
     Lines       25024    25024              
     Branches     3618     3618              
   ==========================================
   - Hits         6835     6826       -9     
   - Misses      17584    17592       +8     
   - Partials      605      606       +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4093/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
   | [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4093/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `44.94% <0%> (-2.25%)` | :arrow_down: |
   | [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4093/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `60.36% <0%> (-0.91%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=footer). Last update [2133669...429a4b3](https://codecov.io/gh/apache/skywalking/pull/4093?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] tuohai666 commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario.

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario. 
URL: https://github.com/apache/skywalking/pull/4093#discussion_r360352806
 
 

 ##########
 File path: test/plugin/scenarios/shardingsphere-3.x-scenario/src/main/java/org/apache/skywalking/apm/testcase/shardingsphere/service/api/service/CommonServiceImpl.java
 ##########
 @@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.testcase.shardingsphere.service.api.service;
+
+import org.apache.skywalking.apm.testcase.shardingsphere.service.api.entity.Order;
+import org.apache.skywalking.apm.testcase.shardingsphere.service.api.entity.OrderItem;
+import org.apache.skywalking.apm.testcase.shardingsphere.service.api.repository.OrderItemRepository;
+import org.apache.skywalking.apm.testcase.shardingsphere.service.api.repository.OrderRepository;
+import java.util.ArrayList;
+import java.util.List;
+
+public abstract class CommonServiceImpl implements CommonService {
+    
+    @Override
+    public void initEnvironment() {
+        getOrderRepository().createTableIfNotExists();
+        getOrderItemRepository().createTableIfNotExists();
+        getOrderRepository().truncateTable();
+        getOrderItemRepository().truncateTable();
+        insertData();
+    }
+    
+    @Override
+    public void cleanEnvironment() {
+        getOrderRepository().dropTable();
+        getOrderItemRepository().dropTable();
+    }
+    
+    @Override
+    public void processSuccess(final boolean isRangeSharding) {
+        System.out.println("-------------- Process Success Begin ---------------");
+        printData(isRangeSharding);
+        System.out.println("-------------- Process Success Finish --------------");
 
 Review comment:
   Git it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] dmsolr commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario.

Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario. 
URL: https://github.com/apache/skywalking/pull/4093#discussion_r360341682
 
 

 ##########
 File path: .github/workflows/plugins-test.yaml
 ##########
 @@ -504,3 +504,28 @@ jobs:
         run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
       - name: Run mysql 5.1.2-8.0.15 (53)
         run: bash test/plugin/run.sh mysql-scenario
+
+  ShardingSphere3x:
+    runs-on: ubuntu-18.04
+    timeout-minutes: 90
+    strategy:
+      fail-fast: true
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          submodules: true
+      - uses: actions/cache@v1
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
+      - uses: actions/setup-java@v1
+        with:
+          java-version: 8
+      - name: Build SkyWalking Agent
+        run: ./mvnw clean package -DskipTests -Pagent >/dev/null
+      - name: Build the Docker image
+        run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
+      - name: Run shardingsphere-3.x-scenario 3.0.0 (1)
+        run: bash test/plugin/run.sh shardingsphere-3.x-scenario
 
 Review comment:
   I think we can add it to the fastest group. Because it has one version only.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario.

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario. 
URL: https://github.com/apache/skywalking/pull/4093#discussion_r360356127
 
 

 ##########
 File path: test/plugin/scenarios/shardingsphere-3.x-scenario/config/expectedData.yaml
 ##########
 @@ -0,0 +1,218 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+registryItems:
+  applications:
+    - {shardingsphere-3.x-scenario: nq 0}
+  instances:
+    - {shardingsphere-3.x-scenario: 1}
+  operationNames:
+    - shardingsphere-3.x-scenario: [/shardingsphere-3.x-scenario/case/healthCheck, /shardingsphere-3.x-scenario/case/execute]
+  heartbeat: []
+segmentItems:
+  - applicationCode: shardingsphere-3.x-scenario
+    segmentSize: not null
+    segments:
+      - segmentId: not null
+        spans:
+          - operationName: /shardingsphere-3.x-scenario/case/healthCheck
+            operationId: 0
+            parentSpanId: -1
+            spanId: 0
+            spanLayer: Http
+            startTime: not null
+            endTime: not null
+            componentId: 1
+            componentName: ''
+            isError: false
+            spanType: Entry
+            peer: ''
+            peerId: 0
+            tags:
+              - {key: url, value: 'http://localhost:8080/shardingsphere-3.x-scenario/case/healthCheck'}
+              - {key: http.method, value: HEAD}
 
 Review comment:
   `healthCheck` is not needed (in both `operationNames` and `segments`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario. 
URL: https://github.com/apache/skywalking/pull/4093#discussion_r360374891
 
 

 ##########
 File path: .github/workflows/plugins-test.yaml
 ##########
 @@ -318,6 +318,8 @@ jobs:
         run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
       - name: Run redisson 3.x (37)
         run: bash test/plugin/run.sh redisson-scenario
+      - name: Run shardingsphere-3.x-scenario 3.0.0 (1)
 
 Review comment:
   You miss the change of group name. `Redisson` -> `Redisson_ShardingSphere`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4093: [test/plugin] immigrate test shardingsphere 3.x scenario. 
URL: https://github.com/apache/skywalking/pull/4093#discussion_r360353899
 
 

 ##########
 File path: .github/workflows/plugins-test.yaml
 ##########
 @@ -504,3 +504,28 @@ jobs:
         run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
       - name: Run mysql 5.1.2-8.0.15 (53)
         run: bash test/plugin/run.sh mysql-scenario
+
+  ShardingSphere3x:
+    runs-on: ubuntu-18.04
+    timeout-minutes: 90
+    strategy:
+      fail-fast: true
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          submodules: true
+      - uses: actions/cache@v1
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
+      - uses: actions/setup-java@v1
+        with:
+          java-version: 8
+      - name: Build SkyWalking Agent
+        run: ./mvnw clean package -DskipTests -Pagent >/dev/null
+      - name: Build the Docker image
+        run: ./mvnw -f test/plugin/pom.xml clean package -DskipTests docker:build -DBUILD_NO=local >/dev/null
+      - name: Run shardingsphere-3.x-scenario 3.0.0 (1)
+        run: bash test/plugin/run.sh shardingsphere-3.x-scenario
 
 Review comment:
   Simply, check this
   
   ![image](https://user-images.githubusercontent.com/5441976/71255067-e17eab00-2367-11ea-9bd9-66682d6a5dfd.png)
   
   Or more details at this page, https://github.com/apache/skywalking/pull/4093/checks?check_run_id=358026747

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services