You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/08/20 15:03:42 UTC

[GitHub] [camel] lburgazzoli opened a new pull request #4109: Lifecycle enhancements

lburgazzoli opened a new pull request #4109:
URL: https://github.com/apache/camel/pull/4109


   I'm sure I messed something and the code is full of typos my eyes can't see.
   
   @davsclaus @gnodet mind reviewing ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] davsclaus commented on a change in pull request #4109: Lifecycle enhancements

Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #4109:
URL: https://github.com/apache/camel/pull/4109#discussion_r474058833



##########
File path: core/camel-base/src/main/java/org/apache/camel/impl/engine/AbstractCamelContext.java
##########
@@ -2757,6 +2810,7 @@ protected void doStartCamel() throws Exception {
         ServiceHelper.startService(lifecycleStrategies);
         for (LifecycleStrategy strategy : lifecycleStrategies) {
             try {
+                strategy.onContextStarting(this);
                 strategy.onContextStart(this);

Review comment:
       Is this the old name onContextStart? And should it have been deprecated or what?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] davsclaus commented on a change in pull request #4109: Lifecycle enhancements

Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #4109:
URL: https://github.com/apache/camel/pull/4109#discussion_r474061822



##########
File path: core/camel-base/src/main/java/org/apache/camel/impl/engine/AbstractCamelContext.java
##########
@@ -2757,6 +2810,7 @@ protected void doStartCamel() throws Exception {
         ServiceHelper.startService(lifecycleStrategies);
         for (LifecycleStrategy strategy : lifecycleStrategies) {
             try {
+                strategy.onContextStarting(this);
                 strategy.onContextStart(this);

Review comment:
       Perfect




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] lburgazzoli merged pull request #4109: Lifecycle enhancements

Posted by GitBox <gi...@apache.org>.
lburgazzoli merged pull request #4109:
URL: https://github.com/apache/camel/pull/4109


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] lburgazzoli commented on a change in pull request #4109: Lifecycle enhancements

Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #4109:
URL: https://github.com/apache/camel/pull/4109#discussion_r474060977



##########
File path: core/camel-base/src/main/java/org/apache/camel/impl/engine/AbstractCamelContext.java
##########
@@ -2757,6 +2810,7 @@ protected void doStartCamel() throws Exception {
         ServiceHelper.startService(lifecycleStrategies);
         for (LifecycleStrategy strategy : lifecycleStrategies) {
             try {
+                strategy.onContextStarting(this);
                 strategy.onContextStart(this);

Review comment:
       yes the old name is [onContextStart](https://github.com/apache/camel/blob/master/core/camel-api/src/main/java/org/apache/camel/spi/LifecycleStrategy.java#L55) and I have deprecated it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] lburgazzoli commented on a change in pull request #4109: Lifecycle enhancements

Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #4109:
URL: https://github.com/apache/camel/pull/4109#discussion_r474060977



##########
File path: core/camel-base/src/main/java/org/apache/camel/impl/engine/AbstractCamelContext.java
##########
@@ -2757,6 +2810,7 @@ protected void doStartCamel() throws Exception {
         ServiceHelper.startService(lifecycleStrategies);
         for (LifecycleStrategy strategy : lifecycleStrategies) {
             try {
+                strategy.onContextStarting(this);
                 strategy.onContextStart(this);

Review comment:
       yes the old name is `onContextStart` and I have deprecated it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org