You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "guixiaowen (via GitHub)" <gi...@apache.org> on 2023/11/24 13:56:00 UTC
[PR] [Improvement] Replace ConfigEntry with ConfigOption in RssSparkConfig #1302 [incubator-uniffle]
guixiaowen opened a new pull request, #1332:
URL: https://github.com/apache/incubator-uniffle/pull/1332
… #1302
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Following this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
Using the ConfigOption to unify all client and server config style.
### Why are the changes needed?
Unify all client and server config style.
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [Improvement] Replace ConfigEntry with ConfigOption in RssSparkConfig #1302 [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1332:
URL: https://github.com/apache/incubator-uniffle/pull/1332#issuecomment-1828959483
Is this in a draft? BTW, please fix the CI failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [Improvement] Replace ConfigEntry with ConfigOption in RssSparkConfig #1302 [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1332:
URL: https://github.com/apache/incubator-uniffle/pull/1332#issuecomment-1826175141
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1332?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`d5de299`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/d5de2993f58060b7f2d719509eaed967ff137ad7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.35% compared to head [(`82e8081`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1332?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.31%.
> Report is 10 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1332 +/- ##
============================================
- Coverage 53.35% 53.31% -0.04%
+ Complexity 2690 2160 -530
============================================
Files 410 337 -73
Lines 23590 15227 -8363
Branches 2003 1413 -590
============================================
- Hits 12587 8119 -4468
+ Misses 10229 6650 -3579
+ Partials 774 458 -316
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1332?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [Improvement] Replace ConfigEntry with ConfigOption in RssSparkConfig #1302 [incubator-uniffle]
Posted by "guixiaowen (via GitHub)" <gi...@apache.org>.
guixiaowen commented on PR #1332:
URL: https://github.com/apache/incubator-uniffle/pull/1332#issuecomment-1825713882
Hi @zuston , could you please help reivew this pr .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [Improvement] Replace ConfigEntry with ConfigOption in RssSparkConfig #1302 [incubator-uniffle]
Posted by "guixiaowen (via GitHub)" <gi...@apache.org>.
guixiaowen closed pull request #1332: [Improvement] Replace ConfigEntry with ConfigOption in RssSparkConfig #1302
URL: https://github.com/apache/incubator-uniffle/pull/1332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org