You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by vinayakshedgeri <gi...@git.apache.org> on 2018/12/03 10:51:15 UTC
[GitHub] zeppelin pull request #3248: [ZEPPELIN-3878] Browser IE 11 not loading Note
GitHub user vinayakshedgeri opened a pull request:
https://github.com/apache/zeppelin/pull/3248
[ZEPPELIN-3878] Browser IE 11 not loading Note
### What is this PR for?
Previous version of the zeppelin supports IE 11 when we updated to zeppelin 0.8.0, Zeppelin web was not loading properly saying the error promise undefined .
### What type of PR is it?
[Bug Fix ]
### Todos
* [ ] -
### What is the Jira issue?
* https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3878
### How should this be tested?
click on any of the existing note in IE 11 browser.
Observation : Note not loading or not reponsive
you can check the error in the console
* First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? Yes
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vinayakshedgeri/zeppelin branch-0.8
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3248.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3248
----
commit a95be7406a335809491c572b6de29e222c96f19e
Author: Vinay <vi...@...>
Date: 2018-12-03T10:43:43Z
[ZEPPELIN-3878] IE 11 not loading Note
Unable to load zeppelin note at IE 11 promise undefined
----
---
[GitHub] zeppelin issue #3248: [ZEPPELIN-3878] Browser IE 11 not loading Note
Posted by vinayakshedgeri <gi...@git.apache.org>.
Github user vinayakshedgeri commented on the issue:
https://github.com/apache/zeppelin/pull/3248
> Thank you. BTW, could you please enable your travis-ci to test your PR? :-)
Can you help me to run the PR ,its my first contribution and if you know any doc/wiki that will fine
I tried to do a build first one failed so triggering again
https://travis-ci.org/vinayakshedgeri/zeppelin/builds/462919073
---
[GitHub] zeppelin issue #3248: [ZEPPELIN-3878] Browser IE 11 not loading Note
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3248
Thank you. BTW, could you please enable your travis-ci for testing Zeppelin? :-)
---
[GitHub] zeppelin issue #3248: [ZEPPELIN-3878] Browser IE 11 not loading Note
Posted by vinayakshedgeri <gi...@git.apache.org>.
Github user vinayakshedgeri commented on the issue:
https://github.com/apache/zeppelin/pull/3248
> BTW, I've got the exact same issue like you when I build branch-0.8. Please wait a min to investigate this issue.
@jongyoul any update one this
---
[GitHub] zeppelin issue #3248: [ZEPPELIN-3878] Browser IE 11 not loading Note
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3248
FYI, https://travis-ci.org/vinayakshedgeri
---
[GitHub] zeppelin issue #3248: [ZEPPELIN-3878] Browser IE 11 not loading Note
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3248
Please rebase your commit. I fixed it now
---
[GitHub] zeppelin issue #3248: [ZEPPELIN-3878] Browser IE 11 not loading Note
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3248
BTW, I've got the exact same issue like you when I build branch-0.8. Please wait a min to investigate this issue.
---
[GitHub] zeppelin issue #3248: [ZEPPELIN-3878] Browser IE 11 not loading Note
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3248
Unfortunately, not. I don't have much time to check this issue. Can you build it on your local machine by cleaning all of maven local repositories like `rm -rf ~/.m2`?
---