You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "onebox-li (via GitHub)" <gi...@apache.org> on 2023/10/24 09:01:33 UTC
[PR] [CELEBORN-1083] Refine TimeSlidingHub code [incubator-celeborn]
onebox-li opened a new pull request, #2033:
URL: https://github.com/apache/incubator-celeborn/pull/2033
### What changes were proposed in this pull request?
Refine some TimeSlidingHub code.
### Why are the changes needed?
Ditto
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1083] Refine TimeSlidingHub code [incubator-celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #2033:
URL: https://github.com/apache/incubator-celeborn/pull/2033#discussion_r1371099675
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/congestcontrol/TimeSlidingHub.java:
##########
@@ -104,7 +103,7 @@ public synchronized void add(long currentTimestamp, N newNode) {
_deque.add(lastNode);
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1083] Refine TimeSlidingHub code [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2033:
URL: https://github.com/apache/incubator-celeborn/pull/2033#issuecomment-1776831097
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2033?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2033](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2033?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ced12a1) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/6dc30d39765f6312579856d421b5f89e26f95a7c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6dc30d3) will **decrease** coverage by `0.12%`.
> Report is 3 commits behind head on main.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #2033 +/- ##
==========================================
- Coverage 46.90% 46.77% -0.12%
==========================================
Files 165 165
Lines 10531 10535 +4
Branches 959 958 -1
==========================================
- Hits 4938 4927 -11
- Misses 5271 5285 +14
- Partials 322 323 +1
```
[see 8 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2033/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1083] Refine TimeSlidingHub code [incubator-celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong closed pull request #2033: [CELEBORN-1083] Refine TimeSlidingHub code
URL: https://github.com/apache/incubator-celeborn/pull/2033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1083] Refine TimeSlidingHub code [incubator-celeborn]
Posted by "onebox-li (via GitHub)" <gi...@apache.org>.
onebox-li commented on code in PR #2033:
URL: https://github.com/apache/incubator-celeborn/pull/2033#discussion_r1371087202
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/congestcontrol/TimeSlidingHub.java:
##########
@@ -104,7 +103,7 @@ public synchronized void add(long currentTimestamp, N newNode) {
_deque.add(lastNode);
Review Comment:
It seems the empty node has updated timestamp here. You can take a look at https://github.com/apache/incubator-celeborn/blob/ced12a18cd6e5c9500a25615c5e82e05bebde49f/worker/src/main/java/org/apache/celeborn/service/deploy/worker/congestcontrol/TimeSlidingHub.java#L102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1083] Refine TimeSlidingHub code [incubator-celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on PR #2033:
URL: https://github.com/apache/incubator-celeborn/pull/2033#issuecomment-1778835556
Merging to main(v0.4.0)/0.3(v0.3.2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1083] Refine TimeSlidingHub code [incubator-celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #2033:
URL: https://github.com/apache/incubator-celeborn/pull/2033#discussion_r1371083141
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/congestcontrol/TimeSlidingHub.java:
##########
@@ -104,7 +103,7 @@ public synchronized void add(long currentTimestamp, N newNode) {
_deque.add(lastNode);
Review Comment:
Seems all empty nodes have same timestamp? Maybe lastNode.getLeft() + intervalPerBucketInMills * index ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1083] Refine TimeSlidingHub code [incubator-celeborn]
Posted by "onebox-li (via GitHub)" <gi...@apache.org>.
onebox-li commented on PR #2033:
URL: https://github.com/apache/incubator-celeborn/pull/2033#issuecomment-1777250739
cc @AngersZhuuuu @boneanxs PTAL if have time :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org