[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #12162: Enhance EncryptAlgorithm and QueryAssistedEncryptAlgorithm

[GitBox <gi...@apache.org>]

strongduanmu commented on a change in pull request #12162:
URL: https://github.com/apache/shardingsphere/pull/12162#discussion_r700822752



##########
File path: shardingsphere-features/shardingsphere-db-discovery/shardingsphere-db-discovery-distsql/shardingsphere-db-discovery-distsql-handler/src/main/java/org/apache/shardingsphere/dbdiscovery/distsql/handler/update/AlterDatabaseDiscoveryRuleStatementUpdater.java
##########
@@ -107,7 +107,7 @@ private void checkToBeAlteredDiscoveryType(final AlterDatabaseDiscoveryRuleState
     }
     
     @Override
-    public RuleConfiguration buildToBeAlteredRuleConfiguration(final AlterDatabaseDiscoveryRuleStatement sqlStatement) {
+    public RuleConfiguration buildToBeAlteredRuleConfiguration(final ShardingSphereMetaData shardingSphereMetaData, final AlterDatabaseDiscoveryRuleStatement sqlStatement) {

Review comment:
       @cheese8 Why add this param? 

##########
File path: shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-api/src/main/java/org/apache/shardingsphere/encrypt/api/config/EncryptRuleConfiguration.java
##########
@@ -34,13 +34,15 @@
 @Getter
 public final class EncryptRuleConfiguration implements SchemaRuleConfiguration, EnhancedRuleConfiguration {
     
+    private final String dataSourceName;

Review comment:
       @cheese8 Why add dataSourceName in EncryptRuleConfiguration? It seems to have an impact on the encrypt api.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org