You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/04/22 09:09:49 UTC
[GitHub] [camel] mash-sap opened a new pull request #5454: CAMEL-16532: Prevent unregistration of existing endpoints after attem…
mash-sap opened a new pull request #5454:
URL: https://github.com/apache/camel/pull/5454
…pt to register a already existing endpoint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mash-sap commented on pull request #5454: CAMEL-16532: Prevent unregistration of existing endpoints after attem…
Posted by GitBox <gi...@apache.org>.
mash-sap commented on pull request #5454:
URL: https://github.com/apache/camel/pull/5454#issuecomment-831149086
The issue is addressed in CXF: https://issues.apache.org/jira/browse/CXF-8533
Closing this pullrequest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mash-sap commented on pull request #5454: CAMEL-16532: Prevent unregistration of existing endpoints after attem…
Posted by GitBox <gi...@apache.org>.
mash-sap commented on pull request #5454:
URL: https://github.com/apache/camel/pull/5454#issuecomment-825131315
I did some testing:
- The start-stop-mbean problem from CAMEL-10914 is still fixed with this change
- New behavior introduced with this change: Dangling mbeans appear when the route startup fails (jira reproducer extended). This is due to the new behavior, that a server.destroy() is only called once the route/server was started
Do you think the downside of this change is acceptable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mash-sap commented on pull request #5454: CAMEL-16532: Prevent unregistration of existing endpoints after attem…
Posted by GitBox <gi...@apache.org>.
mash-sap commented on pull request #5454:
URL: https://github.com/apache/camel/pull/5454#issuecomment-825389832
@tadayosi Yes I agree. I think we can not fix this completly in camel. But this can probably be fixed in CXF. I will report this to the CXF community and try to get some feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mash-sap closed pull request #5454: CAMEL-16532: Prevent unregistration of existing endpoints after attem…
Posted by GitBox <gi...@apache.org>.
mash-sap closed pull request #5454:
URL: https://github.com/apache/camel/pull/5454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #5454: CAMEL-16532: Prevent unregistration of existing endpoints after attem…
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #5454:
URL: https://github.com/apache/camel/pull/5454#issuecomment-826578997
Yeah good idea to get feedback from CXF. It may be that they can make CXF detect the "port in use" sooner and avoid regsitering mbeans and other bits that is harder to cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] tadayosi commented on pull request #5454: CAMEL-16532: Prevent unregistration of existing endpoints after attem…
Posted by GitBox <gi...@apache.org>.
tadayosi commented on pull request #5454:
URL: https://github.com/apache/camel/pull/5454#issuecomment-825378191
> New behavior introduced with this change: Dangling mbeans appear when the route startup fails (jira reproducer extended). This is due to the new behavior, that a server.destroy() is only called once the route/server was started
I am not sure if it's acceptable or not. At this moment, it's the choice between the following two:
- If you try to deploy a duplicate CXF consumer and fail then the existing consumer fails altogether, or
- If you try to deploy any CXF consumer and immediately fail then you'll see a growing number of dangling MBeans.
Ideally, `doStop()` should look for any other running MBean with the same identity and invoke `destroy()` only if there aren't any.
@davsclaus @oscerd What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org