You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/25 14:20:50 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request #1847: Duplicate license headers in Velocity test templates #1843
JiriOndrusek opened a new pull request #1847:
URL: https://github.com/apache/camel-quarkus/pull/1847
Fixes https://github.com/apache/camel-quarkus/issues/1843
Problem was caused locally and should not be committed.
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1847: Duplicate license headers in Velocity test templates #1843
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1847:
URL: https://github.com/apache/camel-quarkus/pull/1847#discussion_r495036733
##########
File path: pom.xml
##########
@@ -421,6 +421,7 @@
<rng>XML_STYLE</rng>
<spring.factories>CAMEL_PROPERTIES_STYLE</spring.factories>
<spring.provides>CAMEL_PROPERTIES_STYLE</spring.provides>
+<tm>CAMEL_PROPERTIES_STYLE</tm>
Review comment:
Just a nit - can you fix up the indentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1847: Duplicate license headers in Velocity test templates #1843
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #1847:
URL: https://github.com/apache/camel-quarkus/pull/1847#discussion_r495043996
##########
File path: pom.xml
##########
@@ -421,6 +421,7 @@
<rng>XML_STYLE</rng>
<spring.factories>CAMEL_PROPERTIES_STYLE</spring.factories>
<spring.provides>CAMEL_PROPERTIES_STYLE</spring.provides>
+<tm>CAMEL_PROPERTIES_STYLE</tm>
Review comment:
tthanks for noticing this. This line is a part of stringtemplate extension (of course with proper indentation)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1847: Duplicate license headers in Velocity test templates #1843
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #1847:
URL: https://github.com/apache/camel-quarkus/pull/1847#discussion_r495042695
##########
File path: pom.xml
##########
@@ -421,6 +421,7 @@
<rng>XML_STYLE</rng>
<spring.factories>CAMEL_PROPERTIES_STYLE</spring.factories>
<spring.provides>CAMEL_PROPERTIES_STYLE</spring.provides>
+<tm>CAMEL_PROPERTIES_STYLE</tm>
Review comment:
@jamesnetherton this line shouldn'e be there atll, my ide didn't show it. I'll remove it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #1847: Duplicate license headers in Velocity test templates #1843
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #1847:
URL: https://github.com/apache/camel-quarkus/pull/1847
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1847: Duplicate license headers in Velocity test templates #1843
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1847:
URL: https://github.com/apache/camel-quarkus/pull/1847#issuecomment-698996872
I have restarted the CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org