You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/08/09 08:03:00 UTC
[GitHub] flink pull request #4501: [FLINK-7352] [tests] Stabilize ExecutionGraphResta...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4501
[FLINK-7352] [tests] Stabilize ExecutionGraphRestartTest
## What is the purpose of the change
Introduce an explicit waiting for the deployment of tasks. This replaces the loose
ordering induced by Thread.sleep and fixes the race conditions caused by it.
## Brief change log
- Introduce `WaitForTasks` consumer which is given to the `SimpleAckingTaskManagerGateway`
- Using a single `SimpleAckingTaskManagerGateway` to receive all task submission calls
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixExecutionGraphRestartTest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4501.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4501
----
commit 40cd0c860dd600ce2baa69b0f0ba8cf7a787ff63
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-08-09T07:57:56Z
[FLINK-7352] [tests] Stabilize ExecutionGraphRestartTest
Introduce an explicit waiting for the deployment of tasks. This replaces the loose
ordering induced by Thread.sleep and fixes the race conditions caused by it.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4501: [FLINK-7352] [tests] Stabilize ExecutionGraphRestartTest
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4501
Travis passes. Merging this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4501: [FLINK-7352] [tests] Stabilize ExecutionGraphResta...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4501
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---