[GitHub] [nuttx] acassis commented on a diff in pull request #8280: Add more battery operation

["acassis (via GitHub)" <gi...@apache.org>]

acassis commented on code in PR #8280:
URL: https://github.com/apache/nuttx/pull/8280#discussion_r1090905217


##########
include/nuttx/power/battery_ioctl.h:
##########
@@ -143,6 +143,7 @@ enum batio_operate_e
   BATIO_OPRTN_SYSON,
   BATIO_OPRTN_RESET,
   BATIO_OPRTN_WDOG,
+  BATIO_OPRTN_SHIPMODE,

Review Comment:
   I was going to suggest a generic name like _STANDBY, but I agree _SHIPMODE is has a sense of purpose. In the automotive industry we use it too when shipping a car from a country to another or even inside big countries



##########
include/nuttx/power/battery_ioctl.h:
##########
@@ -144,6 +144,7 @@ enum batio_operate_e
   BATIO_OPRTN_RESET,
   BATIO_OPRTN_WDOG,
   BATIO_OPRTN_SHIPMODE,
+  BATIO_OPRTN_CUTOFF_CURRENT,

Review Comment:
   Isn't BATIO_OPRTN_CUTOFF_CURRENT equivalent to BATIO_OPRTN_SYSOFF or even BATIO_OPRTN_HIZ ? What is the purpose in this case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org