You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "echobravopapa (GitHub)" <gi...@apache.org> on 2018/11/19 23:31:48 UTC

[GitHub] [geode-native] echobravopapa opened pull request #406: GEODE-4728: Removed all usage of grid client


[ Full content available at: https://github.com/apache/geode-native/pull/406 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] echobravopapa commented on issue #406: GEODE-4728: Removed all usage of grid client

Posted by "echobravopapa (GitHub)" <gi...@apache.org>.
@pivotal-jbarrett please see responses

[ Full content available at: https://github.com/apache/geode-native/pull/406 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #406: GEODE-4728: Removed all usage of grid client

Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Duplicate test?

[ Full content available at: https://github.com/apache/geode-native/pull/406 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] codecov-io commented on issue #406: GEODE-4728: Removed all usage of grid client

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=h1) Report
> Merging [#406](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/geode-native/commit/f19b552c9c9ec68c3f2abeb227b8b0e1e90012ea?src=pr&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `85%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/geode-native/pull/406/graphs/tree.svg?width=650&token=plpAqoqGag&height=150&src=pr)](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #406      +/-   ##
===========================================
+ Coverage    71.77%   71.84%   +0.06%     
===========================================
  Files          647      647              
  Lines        52020    51940      -80     
===========================================
- Hits         37337    37315      -22     
+ Misses       14683    14625      -58
```


| [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n-test/testThinClientTransactionsWithoutSticky.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFRyYW5zYWN0aW9uc1dpdGhvdXRTdGlja3kuY3Bw) | `100% <ø> (ø)` | :arrow_up: |
| [...tion-test/testThinClientTransactionsWithSticky.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFRyYW5zYWN0aW9uc1dpdGhTdGlja3kuY3Bw) | `100% <ø> (ø)` | :arrow_up: |
| [cppcache/integration-test/ThinClientHelper.hpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC9UaGluQ2xpZW50SGVscGVyLmhwcA==) | `76.78% <ø> (+1.36%)` | :arrow_up: |
| [cppcache/src/ThinClientRegion.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWdpb24uY3Bw) | `55.63% <ø> (-0.05%)` | :arrow_down: |
| [cppcache/src/ThinClientPoolHADM.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sSEFETS5jcHA=) | `84.5% <ø> (+1.05%)` | :arrow_up: |
| [cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw) | `62.18% <ø> (-1.34%)` | :arrow_down: |
| [...pcache/integration-test/ThinClientTransactions.hpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC9UaGluQ2xpZW50VHJhbnNhY3Rpb25zLmhwcA==) | `90.23% <ø> (-0.31%)` | :arrow_down: |
| [cppcache/src/ThinClientHARegion.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRIQVJlZ2lvbi5jcHA=) | `75.6% <ø> (+2.88%)` | :arrow_up: |
| [cppcache/src/SystemProperties.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1N5c3RlbVByb3BlcnRpZXMuY3Bw) | `88.29% <ø> (-0.23%)` | :arrow_down: |
| [cppcache/include/geode/SystemProperties.hpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW5jbHVkZS9nZW9kZS9TeXN0ZW1Qcm9wZXJ0aWVzLmhwcA==) | `100% <ø> (ø)` | :arrow_up: |
| ... and [25 more](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=footer). Last update [f19b552...208baaa](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/geode-native/pull/406 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #406: GEODE-4728: Removed all usage of grid client

Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
This may be a redundant test if it was initializing grid client. Is there another test that covers these same methods but didn't init grid?

[ Full content available at: https://github.com/apache/geode-native/pull/406 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] echobravopapa commented on pull request #406: GEODE-4728: Removed all usage of grid client

Posted by "echobravopapa (GitHub)" <gi...@apache.org>.
No, just removes non-sense of toggling `grid-client`

[ Full content available at: https://github.com/apache/geode-native/pull/406 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] echobravopapa commented on pull request #406: GEODE-4728: Removed all usage of grid client

Posted by "echobravopapa (GitHub)" <gi...@apache.org>.
Okay, this test is the `StructSet` version of doing remote queries ... it was exclusively using `grid-client` settings, so it seems a more valuable test than it was before

[ Full content available at: https://github.com/apache/geode-native/pull/406 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett closed pull request #406: GEODE-4728: Removed all usage of grid client

Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
[ pull request closed by pivotal-jbarrett ]

[ Full content available at: https://github.com/apache/geode-native/pull/406 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #406: GEODE-4728: Removed all usage of grid client

Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Does removing this create a duplicate test where the same methods are being exercised already without grid set?

[ Full content available at: https://github.com/apache/geode-native/pull/406 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] codecov-io commented on issue #406: GEODE-4728: Removed all usage of grid client

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=h1) Report
> Merging [#406](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/geode-native/commit/f19b552c9c9ec68c3f2abeb227b8b0e1e90012ea?src=pr&el=desc) will **increase** coverage by `0.15%`.
> The diff coverage is `85%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/geode-native/pull/406/graphs/tree.svg?width=650&token=plpAqoqGag&height=150&src=pr)](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #406      +/-   ##
===========================================
+ Coverage    71.77%   71.92%   +0.15%     
===========================================
  Files          647      647              
  Lines        52020    51940      -80     
===========================================
+ Hits         37337    37359      +22     
+ Misses       14683    14581     -102
```


| [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n-test/testThinClientTransactionsWithoutSticky.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFRyYW5zYWN0aW9uc1dpdGhvdXRTdGlja3kuY3Bw) | `100% <ø> (ø)` | :arrow_up: |
| [...tion-test/testThinClientTransactionsWithSticky.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFRyYW5zYWN0aW9uc1dpdGhTdGlja3kuY3Bw) | `100% <ø> (ø)` | :arrow_up: |
| [cppcache/integration-test/ThinClientHelper.hpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC9UaGluQ2xpZW50SGVscGVyLmhwcA==) | `76.78% <ø> (+1.36%)` | :arrow_up: |
| [cppcache/src/ThinClientRegion.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWdpb24uY3Bw) | `56.03% <ø> (+0.35%)` | :arrow_up: |
| [cppcache/src/ThinClientPoolHADM.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sSEFETS5jcHA=) | `84.5% <ø> (+1.05%)` | :arrow_up: |
| [cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw) | `63.73% <ø> (+0.21%)` | :arrow_up: |
| [...pcache/integration-test/ThinClientTransactions.hpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC9UaGluQ2xpZW50VHJhbnNhY3Rpb25zLmhwcA==) | `90.23% <ø> (-0.31%)` | :arrow_down: |
| [cppcache/src/ThinClientHARegion.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRIQVJlZ2lvbi5jcHA=) | `75.6% <ø> (+2.88%)` | :arrow_up: |
| [cppcache/src/SystemProperties.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1N5c3RlbVByb3BlcnRpZXMuY3Bw) | `88.29% <ø> (-0.23%)` | :arrow_down: |
| [cppcache/include/geode/SystemProperties.hpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW5jbHVkZS9nZW9kZS9TeXN0ZW1Qcm9wZXJ0aWVzLmhwcA==) | `100% <ø> (ø)` | :arrow_up: |
| ... and [26 more](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=footer). Last update [f19b552...208baaa](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/geode-native/pull/406 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] codecov-io commented on issue #406: GEODE-4728: Removed all usage of grid client

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=h1) Report
> Merging [#406](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/geode-native/commit/f19b552c9c9ec68c3f2abeb227b8b0e1e90012ea?src=pr&el=desc) will **increase** coverage by `0.15%`.
> The diff coverage is `85%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/geode-native/pull/406/graphs/tree.svg?width=650&token=plpAqoqGag&height=150&src=pr)](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #406      +/-   ##
===========================================
+ Coverage    71.77%   71.92%   +0.15%     
===========================================
  Files          647      647              
  Lines        52020    51940      -80     
===========================================
+ Hits         37337    37359      +22     
+ Misses       14683    14581     -102
```


| [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n-test/testThinClientTransactionsWithoutSticky.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFRyYW5zYWN0aW9uc1dpdGhvdXRTdGlja3kuY3Bw) | `100% <ø> (ø)` | :arrow_up: |
| [...tion-test/testThinClientTransactionsWithSticky.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFRyYW5zYWN0aW9uc1dpdGhTdGlja3kuY3Bw) | `100% <ø> (ø)` | :arrow_up: |
| [cppcache/integration-test/ThinClientHelper.hpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC9UaGluQ2xpZW50SGVscGVyLmhwcA==) | `76.78% <ø> (+1.36%)` | :arrow_up: |
| [cppcache/src/ThinClientRegion.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWdpb24uY3Bw) | `56.03% <ø> (+0.35%)` | :arrow_up: |
| [cppcache/src/ThinClientPoolHADM.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sSEFETS5jcHA=) | `84.5% <ø> (+1.05%)` | :arrow_up: |
| [cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw) | `63.73% <ø> (+0.21%)` | :arrow_up: |
| [...pcache/integration-test/ThinClientTransactions.hpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC9UaGluQ2xpZW50VHJhbnNhY3Rpb25zLmhwcA==) | `90.23% <ø> (-0.31%)` | :arrow_down: |
| [cppcache/src/ThinClientHARegion.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRIQVJlZ2lvbi5jcHA=) | `75.6% <ø> (+2.88%)` | :arrow_up: |
| [cppcache/src/SystemProperties.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1N5c3RlbVByb3BlcnRpZXMuY3Bw) | `88.29% <ø> (-0.23%)` | :arrow_down: |
| [cppcache/include/geode/SystemProperties.hpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW5jbHVkZS9nZW9kZS9TeXN0ZW1Qcm9wZXJ0aWVzLmhwcA==) | `100% <ø> (ø)` | :arrow_up: |
| ... and [26 more](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=footer). Last update [f19b552...208baaa](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/geode-native/pull/406 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] codecov-io commented on issue #406: GEODE-4728: Removed all usage of grid client

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=h1) Report
> Merging [#406](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/geode-native/commit/f19b552c9c9ec68c3f2abeb227b8b0e1e90012ea?src=pr&el=desc) will **increase** coverage by `0.14%`.
> The diff coverage is `85%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/geode-native/pull/406/graphs/tree.svg?width=650&token=plpAqoqGag&height=150&src=pr)](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #406      +/-   ##
===========================================
+ Coverage    71.77%   71.91%   +0.14%     
===========================================
  Files          647      647              
  Lines        52020    51940      -80     
===========================================
+ Hits         37337    37355      +18     
+ Misses       14683    14585      -98
```


| [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n-test/testThinClientTransactionsWithoutSticky.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFRyYW5zYWN0aW9uc1dpdGhvdXRTdGlja3kuY3Bw) | `100% <ø> (ø)` | :arrow_up: |
| [...tion-test/testThinClientTransactionsWithSticky.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFRyYW5zYWN0aW9uc1dpdGhTdGlja3kuY3Bw) | `100% <ø> (ø)` | :arrow_up: |
| [cppcache/integration-test/ThinClientHelper.hpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC9UaGluQ2xpZW50SGVscGVyLmhwcA==) | `76.78% <ø> (+1.36%)` | :arrow_up: |
| [cppcache/src/ThinClientRegion.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWdpb24uY3Bw) | `56.03% <ø> (+0.35%)` | :arrow_up: |
| [cppcache/src/ThinClientPoolHADM.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sSEFETS5jcHA=) | `84.5% <ø> (+1.05%)` | :arrow_up: |
| [cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw) | `63.73% <ø> (+0.21%)` | :arrow_up: |
| [...pcache/integration-test/ThinClientTransactions.hpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC9UaGluQ2xpZW50VHJhbnNhY3Rpb25zLmhwcA==) | `90.23% <ø> (-0.31%)` | :arrow_down: |
| [cppcache/src/ThinClientHARegion.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRIQVJlZ2lvbi5jcHA=) | `75.6% <ø> (+2.88%)` | :arrow_up: |
| [cppcache/src/SystemProperties.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1N5c3RlbVByb3BlcnRpZXMuY3Bw) | `88.29% <ø> (-0.23%)` | :arrow_down: |
| [cppcache/include/geode/SystemProperties.hpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW5jbHVkZS9nZW9kZS9TeXN0ZW1Qcm9wZXJ0aWVzLmhwcA==) | `100% <ø> (ø)` | :arrow_up: |
| ... and [25 more](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=footer). Last update [f19b552...208baaa](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/geode-native/pull/406 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] codecov-io commented on issue #406: GEODE-4728: Removed all usage of grid client

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=h1) Report
> Merging [#406](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/geode-native/commit/f19b552c9c9ec68c3f2abeb227b8b0e1e90012ea?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `85%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/geode-native/pull/406/graphs/tree.svg?width=650&token=plpAqoqGag&height=150&src=pr)](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #406      +/-   ##
===========================================
+ Coverage    71.76%   71.78%   +0.01%     
===========================================
  Files          647      647              
  Lines        52020    51940      -80     
===========================================
- Hits         37333    37283      -50     
+ Misses       14687    14657      -30
```


| [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n-test/testThinClientTransactionsWithoutSticky.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFRyYW5zYWN0aW9uc1dpdGhvdXRTdGlja3kuY3Bw) | `100% <ø> (ø)` | :arrow_up: |
| [...tion-test/testThinClientTransactionsWithSticky.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFRyYW5zYWN0aW9uc1dpdGhTdGlja3kuY3Bw) | `100% <ø> (ø)` | :arrow_up: |
| [cppcache/integration-test/ThinClientHelper.hpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC9UaGluQ2xpZW50SGVscGVyLmhwcA==) | `76.78% <ø> (+1.36%)` | :arrow_up: |
| [cppcache/src/ThinClientRegion.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWdpb24uY3Bw) | `55.58% <ø> (-0.1%)` | :arrow_down: |
| [cppcache/src/ThinClientPoolHADM.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sSEFETS5jcHA=) | `84.5% <ø> (+1.05%)` | :arrow_up: |
| [cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw) | `62.18% <ø> (-1.34%)` | :arrow_down: |
| [...pcache/integration-test/ThinClientTransactions.hpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC9UaGluQ2xpZW50VHJhbnNhY3Rpb25zLmhwcA==) | `90.23% <ø> (-0.14%)` | :arrow_down: |
| [cppcache/src/ThinClientHARegion.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRIQVJlZ2lvbi5jcHA=) | `75.6% <ø> (+2.88%)` | :arrow_up: |
| [cppcache/src/SystemProperties.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1N5c3RlbVByb3BlcnRpZXMuY3Bw) | `88.29% <ø> (-0.23%)` | :arrow_down: |
| [cppcache/include/geode/SystemProperties.hpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW5jbHVkZS9nZW9kZS9TeXN0ZW1Qcm9wZXJ0aWVzLmhwcA==) | `100% <ø> (ø)` | :arrow_up: |
| ... and [22 more](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=footer). Last update [f19b552...208baaa](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/geode-native/pull/406 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] codecov-io commented on issue #406: GEODE-4728: Removed all usage of grid client

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=h1) Report
> Merging [#406](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/geode-native/commit/f19b552c9c9ec68c3f2abeb227b8b0e1e90012ea?src=pr&el=desc) will **increase** coverage by `0.15%`.
> The diff coverage is `85%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/geode-native/pull/406/graphs/tree.svg?width=650&token=plpAqoqGag&height=150&src=pr)](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #406      +/-   ##
===========================================
+ Coverage    71.77%   71.92%   +0.15%     
===========================================
  Files          647      647              
  Lines        52020    51940      -80     
===========================================
+ Hits         37337    37359      +22     
+ Misses       14683    14581     -102
```


| [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n-test/testThinClientTransactionsWithoutSticky.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFRyYW5zYWN0aW9uc1dpdGhvdXRTdGlja3kuY3Bw) | `100% <ø> (ø)` | :arrow_up: |
| [...tion-test/testThinClientTransactionsWithSticky.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFRyYW5zYWN0aW9uc1dpdGhTdGlja3kuY3Bw) | `100% <ø> (ø)` | :arrow_up: |
| [cppcache/integration-test/ThinClientHelper.hpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC9UaGluQ2xpZW50SGVscGVyLmhwcA==) | `76.78% <ø> (+1.36%)` | :arrow_up: |
| [cppcache/src/ThinClientRegion.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWdpb24uY3Bw) | `56.03% <ø> (+0.35%)` | :arrow_up: |
| [cppcache/src/ThinClientPoolHADM.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sSEFETS5jcHA=) | `84.5% <ø> (+1.05%)` | :arrow_up: |
| [cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw) | `63.73% <ø> (+0.21%)` | :arrow_up: |
| [...pcache/integration-test/ThinClientTransactions.hpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC9UaGluQ2xpZW50VHJhbnNhY3Rpb25zLmhwcA==) | `90.23% <ø> (-0.31%)` | :arrow_down: |
| [cppcache/src/ThinClientHARegion.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRIQVJlZ2lvbi5jcHA=) | `75.6% <ø> (+2.88%)` | :arrow_up: |
| [cppcache/src/SystemProperties.cpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1N5c3RlbVByb3BlcnRpZXMuY3Bw) | `88.29% <ø> (-0.23%)` | :arrow_down: |
| [cppcache/include/geode/SystemProperties.hpp](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW5jbHVkZS9nZW9kZS9TeXN0ZW1Qcm9wZXJ0aWVzLmhwcA==) | `100% <ø> (ø)` | :arrow_up: |
| ... and [26 more](https://codecov.io/gh/apache/geode-native/pull/406/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=footer). Last update [f19b552...208baaa](https://codecov.io/gh/apache/geode-native/pull/406?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/geode-native/pull/406 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] echobravopapa commented on pull request #406: GEODE-4728: Removed all usage of grid client

Posted by "echobravopapa (GitHub)" <gi...@apache.org>.
see above...

[ Full content available at: https://github.com/apache/geode-native/pull/406 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org