[GitHub] [incubator-pinot] liuchang0520 commented on a change in pull request #6778: upload missing LLC segment to segment store by controller periodic task

[GitBox <gi...@apache.org>]

liuchang0520 commented on a change in pull request #6778:
URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r643447035



##########
File path: pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java
##########
@@ -289,7 +289,7 @@ public String uploadLLCSegment(
             String.format("Failed to upload table %s segment %s to segment store", realtimeTableName, segmentName),
             Response.Status.INTERNAL_SERVER_ERROR);
       }
-      return segmentDownloadUrl.getPath();
+      return segmentDownloadUrl.toString();

Review comment:
       This endpoint was introduced in the dependent pr: #6653 . 
   URI.getPath() will return a truncated url, and the previous test case failed to catch it.
   The test case is changed in this pr as well, in pinot-server/src/test/java/org/apache/pinot/server/api/BaseResourceTest.java




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org