[GitHub] [shardingsphere] lanchengx commented on a change in pull request #12623: Refactor Shadow DistSQL and adapt the new data structure of tableConfiguration

[GitBox <gi...@apache.org>]

lanchengx commented on a change in pull request #12623:
URL: https://github.com/apache/shardingsphere/pull/12623#discussion_r714031538



##########
File path: shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-api/src/main/java/org/apache/shardingsphere/shadow/api/config/table/ShadowTableConfiguration.java
##########
@@ -46,4 +46,16 @@ public ShadowTableConfiguration(final Collection<String> shadowAlgorithmNames) {
         this.dataSourceNames = new LinkedList<>();
         this.shadowAlgorithmNames = shadowAlgorithmNames;
     }
+    
+    /**
+     * Aggregate the data of two shadow table configuration.
+     *
+     * @param config new shadow table configuration
+     * @return shadow table configuration
+     */
+    public ShadowTableConfiguration aggregateData(final ShadowTableConfiguration config) {

Review comment:
       I also agree, it has been modified to `mergeConfiguration()` and moved to `ShadowRuleStatementSupporter`, What do you think of this？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org