You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/12/02 04:09:20 UTC
[kudu-CR] [security] a small style-related code cleanup
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20745
Change subject: [security] a small style-related code cleanup
......................................................................
[security] a small style-related code cleanup
Since I'm working on adding new functionality into MiniKdc, I separated
this code-style only part of recent updates into a separate patch.
This patch doesn't contain any functional modifications.
Change-Id: Icfd68a9f7a34235095b4d0f94f57b698a7a71c1d
---
M src/kudu/security/init.cc
M src/kudu/security/test/mini_kdc.cc
M src/kudu/security/test/mini_kdc.h
3 files changed, 57 insertions(+), 58 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/20745/1
--
To view, visit http://gerrit.cloudera.org:8080/20745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icfd68a9f7a34235095b4d0f94f57b698a7a71c1d
Gerrit-Change-Number: 20745
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [security] a small style-related code cleanup
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20745 )
Change subject: [security] a small style-related code cleanup
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd68a9f7a34235095b4d0f94f57b698a7a71c1d
Gerrit-Change-Number: 20745
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 04 Dec 2023 17:38:53 +0000
Gerrit-HasComments: No
[kudu-CR] [security] a small style-related code cleanup
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20745 )
Change subject: [security] a small style-related code cleanup
......................................................................
Patch Set 2: Code-Review+2
carrying over Abhishek's +2 from PS1
--
To view, visit http://gerrit.cloudera.org:8080/20745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd68a9f7a34235095b4d0f94f57b698a7a71c1d
Gerrit-Change-Number: 20745
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Dec 2023 07:20:19 +0000
Gerrit-HasComments: No
[kudu-CR] [security] a small style-related code cleanup
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20745 )
Change subject: [security] a small style-related code cleanup
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd68a9f7a34235095b4d0f94f57b698a7a71c1d
Gerrit-Change-Number: 20745
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Dec 2023 05:56:11 +0000
Gerrit-HasComments: No
[kudu-CR] [security] a small style-related code cleanup
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20745
to look at the new patch set (#2).
Change subject: [security] a small style-related code cleanup
......................................................................
[security] a small style-related code cleanup
Since I'm working on adding new functionality into MiniKdc, I separated
this code-style only part of recent updates into a separate patch.
This patch doesn't contain any functional modifications.
Change-Id: Icfd68a9f7a34235095b4d0f94f57b698a7a71c1d
---
M src/kudu/security/init.cc
M src/kudu/security/test/mini_kdc.cc
M src/kudu/security/test/mini_kdc.h
3 files changed, 58 insertions(+), 59 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/20745/2
--
To view, visit http://gerrit.cloudera.org:8080/20745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfd68a9f7a34235095b4d0f94f57b698a7a71c1d
Gerrit-Change-Number: 20745
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [security] a small style-related code cleanup
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20745 )
Change subject: [security] a small style-related code cleanup
......................................................................
[security] a small style-related code cleanup
Since I'm working on adding new functionality into MiniKdc, I separated
this code-style only part of recent updates into a separate patch.
This patch doesn't contain any functional modifications.
Change-Id: Icfd68a9f7a34235095b4d0f94f57b698a7a71c1d
Reviewed-on: http://gerrit.cloudera.org:8080/20745
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/security/init.cc
M src/kudu/security/test/mini_kdc.cc
M src/kudu/security/test/mini_kdc.h
3 files changed, 58 insertions(+), 59 deletions(-)
Approvals:
Mahesh Reddy: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icfd68a9f7a34235095b4d0f94f57b698a7a71c1d
Gerrit-Change-Number: 20745
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [security] a small style-related code cleanup
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [security] a small style-related code cleanup
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Icfd68a9f7a34235095b4d0f94f57b698a7a71c1d
Gerrit-Change-Number: 20745
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [security] a small style-related code cleanup
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [security] a small style-related code cleanup
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Icfd68a9f7a34235095b4d0f94f57b698a7a71c1d
Gerrit-Change-Number: 20745
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [security] a small style-related code cleanup
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20745 )
Change subject: [security] a small style-related code cleanup
......................................................................
Patch Set 1: Verified+1
unrelated test failure (see KUDU-3524)
--
To view, visit http://gerrit.cloudera.org:8080/20745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd68a9f7a34235095b4d0f94f57b698a7a71c1d
Gerrit-Change-Number: 20745
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 02 Dec 2023 05:10:20 +0000
Gerrit-HasComments: No
[kudu-CR] [security] a small style-related code cleanup
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20745 )
Change subject: [security] a small style-related code cleanup
......................................................................
Patch Set 2: Verified+1
unrelated test failures (mostly KUDU-3524)
--
To view, visit http://gerrit.cloudera.org:8080/20745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd68a9f7a34235095b4d0f94f57b698a7a71c1d
Gerrit-Change-Number: 20745
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Dec 2023 07:19:50 +0000
Gerrit-HasComments: No