You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by andreaturli <gi...@git.apache.org> on 2015/03/24 22:31:18 UTC
[GitHub] incubator-brooklyn pull request: add main uri
GitHub user andreaturli opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/570
add main uri
@grkvlt could you please have a look?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andreaturli/incubator-brooklyn feature/add-riak-main-uri
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/570.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #570
----
commit f872f9ee02ea4878a976a71be141d9dd4715952e
Author: andreaturli <an...@gmail.com>
Date: 2015-03-24T21:30:32Z
add main uri
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: add main uri
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/570#issuecomment-85709289
the error doesn't seem related: unable to find a free port at or above 8080 at [test](https://builds.apache.org/job/incubator-brooklyn-pull-requests/948/org.apache.brooklyn.camp$camp-server/testReport/junit/io.brooklyn.camp.rest.resource/PlatformRestResourceTest/startServer/)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: add main uri
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/570#discussion_r27076300
--- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/riak/RiakNodeSshDriver.java ---
@@ -68,7 +77,7 @@ public RiakNodeImpl getEntity() {
@Override
public Map<String, String> getShellEnvironment() {
MutableMap<String, String> result = MutableMap.copyOf(super.getShellEnvironment());
- // how to change epmd port, according to
+ // how to change epmd port, according to
// http://serverfault.com/questions/582787/how-to-change-listening-interface-of-rabbitmqs-epmd-port-4369
if (getEntity().getEpmdListenerPort() != null) {
result.put("ERL_EPMD_PORT", "" + Integer.toString(getEntity().getEpmdListenerPort()));
--- End diff --
Can you fix this so it doesn't have the `"" + ` part before the `Integer#toString(Integer)` call?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: add main uri
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/570
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: add main uri
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/570#discussion_r27076176
--- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/riak/RiakNodeSshDriver.java ---
@@ -316,6 +325,9 @@ public void launch() {
launchScript.environmentVariablesReset(newPathVariable);
}
launchScript.failOnNonZeroResultCode().execute();
+
+ final String mainUri = String.format("http://%s:%s/admin", entity.getAttribute(Attributes.HOSTNAME), entity.getAttribute(RiakNode.RIAK_WEB_PORT));
--- End diff --
Does it need to be `final`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: add main uri
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/570#issuecomment-86011694
@grkvlt can I merge it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---