[jira] Issue Comment Edited: (DERBY-2760) Clean-up issues for UTF8Util.java

["Kristian Waagan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552743 ] 

kristwaa edited comment on DERBY-2760 at 12/18/07 5:49 AM:
------------------------------------------------------------------

'derby-2760-2b-inner_class.diff' addresses the comments from Dag, and deprecates revision 2a:

- I added a comment (in the class JavaDoc) explaining that the "large" streams are just large enough to pass buffer boundaries.

- I did not add JavaDoc on all public methods, as the names are pretty explanatory. Comments can be added in another patch if wanted.

- I commented the "encoded length bytes" in the class JavaDoc a bit better.

- Fixed typo.

Test coverage is pretty good, but all error situations for the decoding routine are not exercised. I hope to add this in a later patch. This requires some "hand coded" invalid UTF-8 sequences.
In addition I added a sanity test and fixed the incorrect package name in the license header.


thanks,

      was (Author: kristwaa):
    '' addresses the comments from Dag, and deprecates revision 2a:

- I added a comment (in the class JavaDoc) explaining that the "large" streams are just large enough to pass buffer boundaries.

- I did not add JavaDoc on all public methods, as the names are pretty explanatory. Comments can be added in another patch if wanted.

- I commented the "encoded length bytes" in the class JavaDoc a bit better.

- Fixed typo.

Test coverage is pretty good, but all error situations for the decoding routine are not exercised. I hope to add this in a later patch. This requires some "hand coded" invalid UTF-8 sequences.
In addition I added a sanity test and fixed the incorrect package name in the license header.


thanks,
  
> Clean-up issues for UTF8Util.java
> ---------------------------------
>
>                 Key: DERBY-2760
>                 URL: https://issues.apache.org/jira/browse/DERBY-2760
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC
>    Affects Versions: 10.3.1.4
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>            Priority: Trivial
>             Fix For: 10.4.0.0
>
>         Attachments: derby-2760-1a-remove_unused_method.diff, derby-2760-2a-inner_class.diff, derby-2760-2b-inner_class.diff
>
>
> In DERBY-2646, some improvements to org.apache.derby.iapi.util.UTF8Util were suggested:
>   - remove unused private method isDerbyEOFMarker(), or possibly rewrite it to fit into skipInternal()
>   - skipInternal() should return an instance of a private inner class instead of an array

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.