You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2012/10/30 18:28:46 UTC
Re: svn commit: r1403733 -
/subversion/trunk/subversion/libsvn_ra_serf/serf.c
ivan@apache.org wrote on Tue, Oct 30, 2012 at 15:09:57 -0000:
> Author: ivan
> Date: Tue Oct 30 15:09:56 2012
> New Revision: 1403733
>
> URL: http://svn.apache.org/viewvc?rev=1403733&view=rev
> Log:
> * subversion/libsvn_ra_serf/serf.c
> (svn_ra_serf__open): Use whitespace instead of '/' as delimiter for
> custom user-agent string.
>
> Modified:
> subversion/trunk/subversion/libsvn_ra_serf/serf.c
>
> Modified: subversion/trunk/subversion/libsvn_ra_serf/serf.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/serf.c?rev=1403733&r1=1403732&r2=1403733&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_ra_serf/serf.c (original)
> +++ subversion/trunk/subversion/libsvn_ra_serf/serf.c Tue Oct 30 15:09:56 2012
> @@ -417,7 +417,7 @@ svn_ra_serf__open(svn_ra_session_t *sess
> callbacks->get_client_string(callback_baton, &client_string, pool);
>
> if (client_string)
> - serf_sess->useragent = apr_pstrcat(pool, USER_AGENT, "/",
> + serf_sess->useragent = apr_pstrcat(pool, USER_AGENT, " ",
Change libsvn_ra_svn/client.c:open_session too in the same way?
> client_string, (char *)NULL);
> else
> serf_sess->useragent = USER_AGENT;
>
>
Re: svn commit: r1403733 - /subversion/trunk/subversion/libsvn_ra_serf/serf.c
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On Tue, Oct 30, 2012 at 9:28 PM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> ivan@apache.org wrote on Tue, Oct 30, 2012 at 15:09:57 -0000:
>> Author: ivan
>> Date: Tue Oct 30 15:09:56 2012
>> New Revision: 1403733
>>
>> URL: http://svn.apache.org/viewvc?rev=1403733&view=rev
>> Log:
>> * subversion/libsvn_ra_serf/serf.c
>> (svn_ra_serf__open): Use whitespace instead of '/' as delimiter for
>> custom user-agent string.
>>
>> Modified:
>> subversion/trunk/subversion/libsvn_ra_serf/serf.c
>>
>> Modified: subversion/trunk/subversion/libsvn_ra_serf/serf.c
>> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/serf.c?rev=1403733&r1=1403732&r2=1403733&view=diff
>> ==============================================================================
>> --- subversion/trunk/subversion/libsvn_ra_serf/serf.c (original)
>> +++ subversion/trunk/subversion/libsvn_ra_serf/serf.c Tue Oct 30 15:09:56 2012
>> @@ -417,7 +417,7 @@ svn_ra_serf__open(svn_ra_session_t *sess
>> callbacks->get_client_string(callback_baton, &client_string, pool);
>>
>> if (client_string)
>> - serf_sess->useragent = apr_pstrcat(pool, USER_AGENT, "/",
>> + serf_sess->useragent = apr_pstrcat(pool, USER_AGENT, " ",
>
> Change libsvn_ra_svn/client.c:open_session too in the same way?
>
Agree. Done in r1404019.
--
Ivan Zhakov