You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Virag Kothari <vi...@yahoo-inc.com> on 2012/04/24 03:55:07 UTC
Review Request: Oozie-819: Interrupt map doesn't have unique set of commands
for a given jobid
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4851/
-----------------------------------------------------------
Review request for oozie.
Summary
-------
https://issues.apache.org/jira/browse/OOZIE-819
This addresses bug oozie-819.
https://issues.apache.org/jira/browse/oozie-819
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1327678
trunk/core/src/main/java/org/apache/oozie/service/CallableQueueService.java 1327678
trunk/core/src/main/resources/oozie-default.xml 1327678
Diff: https://reviews.apache.org/r/4851/diff
Testing
-------
Tested after runnning examples
Thanks,
Virag
Re: Review Request: Oozie-819: Interrupt map doesn't have unique set of
commands for a given jobid
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4851/#review7393
-----------------------------------------------------------
Ship it!
+1 committing
- Mohammad
On 2012-04-27 22:38:33, Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4851/
> -----------------------------------------------------------
>
> (Updated 2012-04-27 22:38:33)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-819
>
>
> This addresses bug oozie-819.
> https://issues.apache.org/jira/browse/oozie-819
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1327678
> trunk/core/src/main/java/org/apache/oozie/service/CallableQueueService.java 1327678
> trunk/core/src/main/resources/oozie-default.xml 1327678
>
> Diff: https://reviews.apache.org/r/4851/diff
>
>
> Testing
> -------
>
> Tested after runnning examples
>
>
> Thanks,
>
> Virag
>
>
Re: Review Request: Oozie-819: Interrupt map doesn't have unique set of
commands for a given jobid
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4851/
-----------------------------------------------------------
(Updated 2012-04-27 22:38:33.833947)
Review request for oozie.
Changes
-------
Changing from hashset to linkedhashset to preserve insertion order for interruptcmds
Summary
-------
https://issues.apache.org/jira/browse/OOZIE-819
This addresses bug oozie-819.
https://issues.apache.org/jira/browse/oozie-819
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1327678
trunk/core/src/main/java/org/apache/oozie/service/CallableQueueService.java 1327678
trunk/core/src/main/resources/oozie-default.xml 1327678
Diff: https://reviews.apache.org/r/4851/diff
Testing
-------
Tested after runnning examples
Thanks,
Virag
Re: Review Request: Oozie-819: Interrupt map doesn't have unique set of
commands for a given jobid
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4851/
-----------------------------------------------------------
(Updated 2012-04-27 16:30:36.963695)
Review request for oozie.
Changes
-------
setting used variable only if the interrupt cmd is sure to get executed
Summary
-------
https://issues.apache.org/jira/browse/OOZIE-819
This addresses bug oozie-819.
https://issues.apache.org/jira/browse/oozie-819
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1327678
trunk/core/src/main/java/org/apache/oozie/service/CallableQueueService.java 1327678
trunk/core/src/main/resources/oozie-default.xml 1327678
Diff: https://reviews.apache.org/r/4851/diff
Testing
-------
Tested after runnning examples
Thanks,
Virag
Re: Review Request: Oozie-819: Interrupt map doesn't have unique set of
commands for a given jobid
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4851/#review7195
-----------------------------------------------------------
Ensuring unique job-id for specific command type is essential. Good catch!
- Mona
On 2012-04-24 01:55:07, Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4851/
> -----------------------------------------------------------
>
> (Updated 2012-04-24 01:55:07)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-819
>
>
> This addresses bug oozie-819.
> https://issues.apache.org/jira/browse/oozie-819
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1327678
> trunk/core/src/main/java/org/apache/oozie/service/CallableQueueService.java 1327678
> trunk/core/src/main/resources/oozie-default.xml 1327678
>
> Diff: https://reviews.apache.org/r/4851/diff
>
>
> Testing
> -------
>
> Tested after runnning examples
>
>
> Thanks,
>
> Virag
>
>