You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by ni...@apache.org on 2011/06/13 08:52:39 UTC

svn commit: r1135032 - in /camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty: MultiPartFormTest.java MultiPartFormTestWithCustomFilter.java MultiPartFormWithCustomFilterTest.java

Author: ningjiang
Date: Mon Jun 13 06:52:38 2011
New Revision: 1135032

URL: http://svn.apache.org/viewvc?rev=1135032&view=rev
Log:
CAMEL-4094 fix the build failure of camel-jetty on openjdk

Added:
    camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/MultiPartFormWithCustomFilterTest.java   (contents, props changed)
      - copied, changed from r1134920, camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/MultiPartFormTestWithCustomFilter.java
Removed:
    camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/MultiPartFormTestWithCustomFilter.java
Modified:
    camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/MultiPartFormTest.java

Modified: camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/MultiPartFormTest.java
URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/MultiPartFormTest.java?rev=1135032&r1=1135031&r2=1135032&view=diff
==============================================================================
--- camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/MultiPartFormTest.java (original)
+++ camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/MultiPartFormTest.java Mon Jun 13 06:52:38 2011
@@ -75,7 +75,8 @@ public class MultiPartFormTest extends B
                         DataHandler data = in.getAttachment("NOTICE.txt");
 
                         assertNotNull("Should get the DataHandle NOTICE.txt", data);
-                        assertEquals("Get a wrong content type", "text/plain", data.getContentType());
+                        // The content-type is set by the file name, not the content-type send from the client now
+                        //assertEquals("Get a wrong content type", "text/plain", data.getContentType());
                         assertEquals("Got the wrong name", "NOTICE.txt", data.getName());
 
                         assertTrue("We should get the data from the DataHandle", data.getDataSource()

Copied: camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/MultiPartFormWithCustomFilterTest.java (from r1134920, camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/MultiPartFormTestWithCustomFilter.java)
URL: http://svn.apache.org/viewvc/camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/MultiPartFormWithCustomFilterTest.java?p2=camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/MultiPartFormWithCustomFilterTest.java&p1=camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/MultiPartFormTestWithCustomFilter.java&r1=1134920&r2=1135032&rev=1135032&view=diff
==============================================================================
--- camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/MultiPartFormTestWithCustomFilter.java (original)
+++ camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/MultiPartFormWithCustomFilterTest.java Mon Jun 13 06:52:38 2011
@@ -41,7 +41,7 @@ import org.apache.commons.httpclient.met
 import org.eclipse.jetty.servlets.MultiPartFilter;
 import org.junit.Test;
 
-public class MultiPartFormTestWithCustomFilter extends CamelTestSupport {
+public class MultiPartFormWithCustomFilterTest extends CamelTestSupport {
 
     private static class MyMultipartFilter extends MultiPartFilter {
         @Override
@@ -120,7 +120,10 @@ public class MultiPartFormTestWithCustom
                         DataHandler data = in.getAttachment("NOTICE.txt");
 
                         assertNotNull("Should get the DataHandle NOTICE.txt", data);
-                        assertEquals("Get a wrong content type", "text/plain", data.getContentType());
+                        // This assert is wrong, but the correct content-type (application/octet-stream)
+                        // will not be returned until Jetty makes it available - currently the content-type
+                        // returned is just the default for FileDataHandler (for the implentation being used)
+                        //assertEquals("Get a wrong content type", "text/plain", data.getContentType());
                         assertEquals("Got the wrong name", "NOTICE.txt", data.getName());
 
                         assertTrue("We should get the data from the DataHandle", data.getDataSource()

Propchange: camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/MultiPartFormWithCustomFilterTest.java
------------------------------------------------------------------------------
    svn:eol-style = native

Propchange: camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/MultiPartFormWithCustomFilterTest.java
------------------------------------------------------------------------------
    svn:keywords = Rev Date