You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by vi...@apache.org on 2026/09/18 00:29:33 UTC
(spark-connect-gateway) branch main updated: [SPARK-59550] Group coupled crate families in dependabot updates
This is an automated email from the ASF dual-hosted git repository.
viirya pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/spark-connect-gateway.git
The following commit(s) were added to refs/heads/main by this push:
new 4015aac [SPARK-59550] Group coupled crate families in dependabot updates
4015aac is described below
commit 4015aacbfcd02ec7568746da3dc3e69fb798f13a
Author: Liang-Chi Hsieh <vi...@gmail.com>
AuthorDate: Thu Sep 17 17:29:26 2026 -0700
[SPARK-59550] Group coupled crate families in dependabot updates
### What changes were proposed in this pull request?
Add `.github/dependabot.yml` so dependabot raises coupled crate families in one
PR instead of one crate at a time, and skips patch-level updates.
Three groups:
| group | crates | why they are coupled |
|---|---|---|
| `opentelemetry` | 7 | the `opentelemetry*` family plus `tracing-opentelemetry`, whose version is offset by one minor (0.33 tracks opentelemetry 0.32) |
| `tonic-prost` | 6 | `tonic-prost` depends on `tonic` and `prost`, `tonic-health` on `tonic` and `tonic-prost`, and `opentelemetry-proto` on `tonic` and `prost` as well |
| `kube` | 2 | `kube` depends on `k8s-openapi`, whose version selects the Kubernetes API version its generated types target |
Patch-level updates are ignored for every dependency.
### Why are the changes needed?
Crates in these families share types across their public APIs, so bumping one
member on its own leaves two major versions of the family in the dependency graph
and the traits stop lining up. A PR in that state cannot be made green by
rerunning it — it is unmergeable by construction.
That is not hypothetical. Dependabot opened #8 to bump `opentelemetry_sdk` alone;
it was closed as unmergeable, and the upgrade that actually worked
(SPARK-59548, #27) had to move all seven `opentelemetry*` crates **and**
`tracing-opentelemetry` together. Without grouping, dependabot will keep opening
that same PR every time any one of these crates releases.
Patch updates are ignored because dependencies here are pinned by minor and
`Cargo.lock` is committed, so patch PRs are noise — a real patch pickup rides
along with the next minor bump or a deliberate `cargo update`. Happy to drop that
part if you would rather see them.
### Does this PR introduce _any_ user-facing change?
No. Dependabot configuration only; no dependency versions change here and no code
is touched.
### How was this patch tested?
A config file is only useful if it takes effect, and a bad `dependabot.yml` is
ignored silently rather than reported, so I checked it three ways instead of
eyeballing it.
**The patterns match the intended crates and nothing else.** Matched with
`fnmatch` against the real names in `[workspace.dependencies]`:
```
opentelemetry: opentelemetry, opentelemetry-otlp, opentelemetry-proto,
opentelemetry-semantic-conventions, opentelemetry-stdout,
opentelemetry_sdk, tracing-opentelemetry (7)
tonic-prost: prost, prost-types, tonic, tonic-health,
tonic-prost, tonic-prost-build (6)
kube: k8s-openapi, kube (2)
```
Note `opentelemetry_sdk` needs the `opentelemetry_*` pattern separately from
`opentelemetry-*` — the underscore would otherwise be missed.
**Nothing is over-matched.** `tracing` and `tracing-subscriber` stay ungrouped, as
they should: they carry no version coupling to OpenTelemetry, and a `tracing-*`
pattern would have swept them in and needlessly held their updates behind the
OpenTelemetry family.
**The coupling itself was verified, not assumed** — each relationship above was
read out of `Cargo.lock`'s dependency lists rather than inferred from the crate
names. That is how the `kube` / `k8s-openapi` pair was found; it was not in the
original scope.
The schema was also checked against dependabot v2's permitted keys for `updates`,
`groups` and `ignore` entries: no unknown fields.
### Was this patch authored or co-authored using generative AI tooling?
Yes, co-authored with Claude Code.
Closes #28 from viirya/ci-10-dependabot-groups.
Authored-by: Liang-Chi Hsieh <vi...@gmail.com>
Signed-off-by: Liang-Chi Hsieh <li...@databricks.com>
---
.github/dependabot.yml | 59 ++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 59 insertions(+)
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
new file mode 100644
index 0000000..2ed8f7d
--- /dev/null
+++ b/.github/dependabot.yml
@@ -0,0 +1,59 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: 2
+updates:
+ - package-ecosystem: cargo
+ directory: /
+ schedule:
+ interval: weekly
+ open-pull-requests-limit: 5
+ # Families whose crates share types across their public APIs: raising one
+ # crate on its own leaves two major versions of the family in the dependency
+ # graph, and the traits stop lining up. Such a PR cannot be made green by
+ # rerunning it, so grouping is what makes these updates reviewable at all.
+ groups:
+ # The whole OpenTelemetry family, including `tracing-opentelemetry`, whose
+ # version is offset by one minor (0.33 tracks opentelemetry 0.32). A
+ # single-crate bump here was closed as unmergeable; see SPARK-59548.
+ opentelemetry:
+ patterns:
+ - "opentelemetry"
+ - "opentelemetry-*"
+ - "opentelemetry_*"
+ - "tracing-opentelemetry"
+ # tonic and prost move together: tonic-prost depends on both, tonic-health
+ # depends on tonic and tonic-prost, and opentelemetry-proto depends on
+ # tonic and prost as well.
+ tonic-prost:
+ patterns:
+ - "tonic"
+ - "tonic-*"
+ - "prost"
+ - "prost-*"
+ # kube depends on k8s-openapi, and k8s-openapi's version selects the
+ # Kubernetes API version its generated types target, so the two have to
+ # agree.
+ kube:
+ patterns:
+ - "kube"
+ - "k8s-openapi"
+ ignore:
+ # Rust dependencies are pinned by minor here and the lockfile is committed,
+ # so patch-level PRs are noise; a real patch pickup rides along with the
+ # next minor bump or a deliberate `cargo update`.
+ - dependency-name: "*"
+ update-types:
+ - version-update:semver-patch
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org