You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/31 19:30:21 UTC
[GitHub] [airflow] potiuk opened a new pull request, #26091: Improve the speed and stability of KPO tests
potiuk opened a new pull request, #26091:
URL: https://github.com/apache/airflow/pull/26091
The KPO tests were occasionally failing in CI because of race
condition between delete from previous test and running the
following tests. Simply speaking the pods run via KPO well
not immediately sometimes and the following test picked them
together with the current pod and failed becasue of duplicate
pods. There was even a tearDown Delay of 1 second introduced
as workaround to combat this problem.
This PR fixes it much better. Each POD in the KPO test gets
unique label (derived from test name) and when executing the
POD this label is then used as selector, so that only the
**just started** POD in current test are selected - not any
dangling pod (being deleted) from the previous tests.
This not only removes flakiness of the tests, but also remove
the need of sleep, which speeds up the whole suite by whoooping
33 seconds (there were 33 tests to run).
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26091: Improve the speed and stability of KPO tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26091:
URL: https://github.com/apache/airflow/pull/26091#issuecomment-1233343789
@ephraimbuddy @dstandish @jedcunningham That was also the last blocker from #25678 which vastly improves the experience of running K8S tests and makes them exactly 1-1 to what CI will have.
I actually debugged and fixed the problem using the tools from #25678 and following the TESTING.rst guideline there on how to test (both got slightly improved as a result of this investigation and fix) - so I was eating our own dog food.
I also know how to make it even better experience (By develoiping that I learned that new `Kind` apparently has ready-to use features for mounting sources to running containers so we will be able to have a great development experience for K8S as well with realy quick iterations and feedback loop) without using Okteto or manually configuring Docker Desktop @jedcunningham (our recent discussions) right after we merge #25678 as follow-up.. I am excited :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #26091: Improve the speed and stability of KPO tests
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26091:
URL: https://github.com/apache/airflow/pull/26091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org