[GitHub] [incubator-doris] stdpain commented on a change in pull request #5124: [Compaction] Fix bug and add graceful exit for compaction producer

[GitBox <gi...@apache.org>]

stdpain commented on a change in pull request #5124:
URL: https://github.com/apache/incubator-doris/pull/5124#discussion_r554881693



##########
File path: be/src/olap/olap_server.cpp
##########
@@ -390,7 +379,7 @@ void StorageEngine::_compaction_tasks_producer_callback() {
         } else {
             sleep(config::check_auto_compaction_interval_seconds);
         }
-    }
+    } while (!_stop_background_threads_latch.wait_for(MonoDelta::FromMilliseconds(interval)));

Review comment:
       @weizuo93 @acelyc111 
   Is _compaction_thread_pool also need call shutdown?
   It seems _compaction_thread_pool still depend on 'this->_permit_limiter'
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org