You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2018/11/09 17:05:19 UTC

Review Request 69304: ATLAS-2491: updated Hive hook to recognize configuration 'hdfs_path.convert_to_lowercase'

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69304/
-----------------------------------------------------------

Review request for atlas, Abhishek Kadam, Ashutosh Mestry, keval bhatt, Kapildeo Nayak, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-2491
    https://issues.apache.org/jira/browse/ATLAS-2491


Repository: atlas


Description
-------

Updated Hive hook to recognize configuration hdfs_path.convert_to_lowercase.


Diffs
-----

  addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java d6a1b3705 
  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java b467f4c46 
  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 501eb636b 
  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java 9109a0fd5 


Diff: https://reviews.apache.org/r/69304/diff/1/


Testing
-------

Pre-commit test run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/787/


Thanks,

Madhan Neethiraj


Re: Review Request 69304: ATLAS-2491: updated Hive hook to recognize configuration 'hdfs_path.convert_to_lowercase'

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69304/
-----------------------------------------------------------

(Updated Nov. 10, 2018, 9:20 p.m.)


Review request for atlas, Abhishek Kadam, Ashutosh Mestry, keval bhatt, Kapildeo Nayak, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.


Changes
-------

updated default behavior to not lower-case HDFS paths, to be consistent with HDFS - where path is case sensitive.


Bugs: ATLAS-2491
    https://issues.apache.org/jira/browse/ATLAS-2491


Repository: atlas


Description
-------

Updated Hive hook to recognize configuration hdfs_path.convert_to_lowercase.


Diffs (updated)
-----

  addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java d6a1b3705 
  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java b467f4c46 
  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 501eb636b 
  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java 9109a0fd5 


Diff: https://reviews.apache.org/r/69304/diff/2/

Changes: https://reviews.apache.org/r/69304/diff/1-2/


Testing
-------

Pre-commit test run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/787/


Thanks,

Madhan Neethiraj


Re: Review Request 69304: ATLAS-2491: updated Hive hook to recognize configuration 'hdfs_path.convert_to_lowercase'

Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69304/#review210441
-----------------------------------------------------------


Ship it!




Ship It!

- Ashutosh Mestry


On Nov. 9, 2018, 5:05 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69304/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2018, 5:05 p.m.)
> 
> 
> Review request for atlas, Abhishek Kadam, Ashutosh Mestry, keval bhatt, Kapildeo Nayak, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2491
>     https://issues.apache.org/jira/browse/ATLAS-2491
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Updated Hive hook to recognize configuration hdfs_path.convert_to_lowercase.
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java d6a1b3705 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java b467f4c46 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 501eb636b 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java 9109a0fd5 
> 
> 
> Diff: https://reviews.apache.org/r/69304/diff/1/
> 
> 
> Testing
> -------
> 
> Pre-commit test run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/787/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>