You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/12/08 07:03:28 UTC
[PR] [SPARK-46324][SQL] Fix the output name of pyspark.sql.functions.user and session_user [spark]
HyukjinKwon opened a new pull request, #44253:
URL: https://github.com/apache/spark/pull/44253
### What changes were proposed in this pull request?
This PR proposes to fix `user()` and `session_user()` to have the same names in its output name.
### Why are the changes needed?
To show the correct name of the functions being used.
### Does this PR introduce _any_ user-facing change?
Yes.
```scala
spark.range(1).select(user(), session_user()).show()
```
Before:
```
+--------------+--------------+
|current_user()|current_user()|
+--------------+--------------+
| hyukjin.kwon| hyukjin.kwon|
+--------------+--------------+
```
After:
```
+--------------+--------------+
| user()|session_user()|
+--------------+--------------+
| hyukjin.kwon| hyukjin.kwon|
+--------------+--------------+
```
### How was this patch tested?
Manually tested, and unittests were added.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46324][SQL][PYTHON] Fix the output name of pyspark.sql.functions.user and session_user [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #44253: [SPARK-46324][SQL][PYTHON] Fix the output name of pyspark.sql.functions.user and session_user
URL: https://github.com/apache/spark/pull/44253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46324][SQL][PYTHON] Fix the output name of pyspark.sql.functions.user and session_user [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44253:
URL: https://github.com/apache/spark/pull/44253#issuecomment-1847988831
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46324][SQL][PYTHON] Fix the output name of pyspark.sql.functions.user and session_user [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44253:
URL: https://github.com/apache/spark/pull/44253#issuecomment-1847569277
Could you re-trigger the failed pipelines once more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46324][SQL][PYTHON] Fix the output name of pyspark.sql.functions.user and session_user [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44253:
URL: https://github.com/apache/spark/pull/44253#issuecomment-1847826582
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46324][SQL][PYTHON] Fix the output name of pyspark.sql.functions.user and session_user [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #44253:
URL: https://github.com/apache/spark/pull/44253#issuecomment-1846742174
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org