You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Martin Skopp <sk...@riege.de> on 2003/05/09 15:30:12 UTC

patch to enable docbook:transform offline, please commit

Hi all commiters,

I have patched the docbook plugin to allow DTD check against a local
docbook dtd (for offline processing).
Localtion of the docbook dtd is specified by new property
"maven.docbook.dtd"

Could please someone commit my patch to CVS?

Thanks in advance,
Martin

--- CUT HERE ---
Index: plugin.jelly
===================================================================
RCS file: /home/cvspublic/maven/src/plugins-build/docbook/plugin.jelly,v
retrieving revision 1.4
diff -u -r1.4 plugin.jelly
--- plugin.jelly	27 Mar 2003 13:14:25 -0000	1.4
+++ plugin.jelly	9 May 2003 13:23:25 -0000
@@ -15,13 +15,29 @@
      
value="${pom.getPluginContext('maven-xdoc-plugin').getVariable('maven.gen.docs')}"/>

    
${systemScope.setProperty('javax.xml.transform.TransformerFactory','org.apache.xalan.processor.TransformerFactoryImpl')}
-    <ant:style
-      basedir="${maven.docbook.src}"
-      destdir="${genDocs}" extension=".xml"
-      style="${plugin.resources}/docbook2document.xsl"
-      includes="**/*.xml, **/*.sgml"
-    />
-
+    <j:set var="dtd" value="${maven.docbook.dtd}"/>
+    <j:if test="${empty(dtd)}">
+      <ant:style
+        basedir="${maven.docbook.src}"
+        destdir="${genDocs}" extension=".xml"
+        style="${plugin.resources}/docbook2document.xsl"
+        includes="**/*.xml, **/*.sgml"
+      />
+    </j:if>
+    <j:if test="${!empty(dtd)}">
+       <echo>Using offline DocBook DTD ${maven.docbook.dtd}</echo>
+       <ant:style
+        basedir="${maven.docbook.src}"
+        destdir="${genDocs}" extension=".xml"
+        style="${plugin.resources}/docbook2document.xsl"
+        includes="**/*.xml, **/*.sgml">
+        <ant:xmlcatalog id="cat">
+          <ant:dtd
+            publicId="-//OASIS//DTD DocBook XML V4.1.2//EN"
+            location="${maven.docbook.dtd}"/>
+        </ant:xmlcatalog>
+      </ant:style>
+    </j:if>
   </goal>
 </project>
Index: xdocs/properties.xml
===================================================================
RCS file:
/home/cvspublic/maven/src/plugins-build/docbook/xdocs/properties.xml,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 properties.xml
--- xdocs/properties.xml	24 Jan 2003 03:45:09 -0000	1.1.1.1
+++ xdocs/properties.xml	9 May 2003 13:23:25 -0000
@@ -22,6 +22,17 @@
             source directory for the simple docbook xml files
           </td>
         </tr>
+        <tr>
+          <td>maven.docbook.dtd</td>
+          <td>Yes</td>
+          <td>
+            If set, it points to the offline DocBook DTD.
+            This allows offline transformation and DTD checking.
+            DocBook DTD is available for download at
+            <a
href="http://www.oasis-open.org/docbook/xml/4.1.2/index.shtml">http://www.oasis-open.org/docbook/xml/4.1.2/index.shtml</a>.
+            Example value: "/home/msk/docbook-dtd/docbookx.dtd"
+          </td>
+        </tr>
       </table>
     </section>
   </body>
--- CUT HERE ---

-- 
Martin Skopp
Riege Software International GmbH
Support: mailto:maint@riege.com, Information: http://www.riege.com

This email is intended to be viewed with a nonproportional font.
Public Key on http://www.keyserver.net, Key-ID: 3D4027B5
Fingerprint: 1970 C78D 9A1D 99FA 5CE4  5C0D 29E6 6A95 3D40 27B5


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: patch to enable docbook:transform offline, please commit

Posted by Martin Skopp <sk...@riege.de>.
On Tue, 2003-05-20 at 02:38, dion@multitask.com.au wrote:
> Is it possible to raise this as a bug report in jira.codehaus.org and 
> attach the diff. Working with inline diff files is tedious and error 
> prone, an attachment is lots better.

Thanks for info - sure that's possible - I raised MAVEN-436

http://jira.codehaus.org/secure/views/navigator/ViewIssue.jspa?key=MAVEN-436
-- 
Martin Skopp
Riege Software International GmbH
Support: mailto:maint@riege.com, Information: http://www.riege.com

This email is intended to be viewed with a nonproportional font.
Public Key on http://www.keyserver.net, Key-ID: 3D4027B5
Fingerprint: 1970 C78D 9A1D 99FA 5CE4  5C0D 29E6 6A95 3D40 27B5


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: patch to enable docbook:transform offline, please commit

Posted by di...@multitask.com.au.
Lack of time....

Is it possible to raise this as a bug report in jira.codehaus.org and 
attach the diff. Working with inline diff files is tedious and error 
prone, an attachment is lots better.
--
dIon Gillard, Multitask Consulting
Blog:      http://www.freeroller.net/page/dion/Weblog
Work:      http://www.multitask.com.au


Martin Skopp <sk...@riege.de> wrote on 19/05/2003 04:46:44 PM:

> Pretty please could at least someone reply and say why nobody with r/w
> access to CVS did the commit?
> Thanks,
> MSK
> 
> On Fri, 2003-05-09 at 15:30, Martin Skopp wrote:
> > Hi all commiters,
> > 
> > I have patched the docbook plugin to allow DTD check against a local
> > docbook dtd (for offline processing).
> > Localtion of the docbook dtd is specified by new property
> > "maven.docbook.dtd"
> > 
> > Could please someone commit my patch to CVS?
> > 
> > Thanks in advance,
> > Martin
> > 
> > --- CUT HERE ---
> > Index: plugin.jelly
> > ===================================================================
> > RCS file: 
/home/cvspublic/maven/src/plugins-build/docbook/plugin.jelly,v
> > retrieving revision 1.4
> > diff -u -r1.4 plugin.jelly
> > --- plugin.jelly   27 Mar 2003 13:14:25 -0000   1.4
> > +++ plugin.jelly   9 May 2003 13:23:25 -0000
> > @@ -15,13 +15,29 @@
> > 
> > value="${pom.getPluginContext('maven-xdoc-plugin').
> getVariable('maven.gen.docs')}"/>
> > 
> > 
> > ${systemScope.setProperty('javax.xml.transform.
> 
TransformerFactory','org.apache.xalan.processor.TransformerFactoryImpl')}
> > -    <ant:style
> > -      basedir="${maven.docbook.src}"
> > -      destdir="${genDocs}" extension=".xml"
> > -      style="${plugin.resources}/docbook2document.xsl"
> > -      includes="**/*.xml, **/*.sgml"
> > -    />
> > -
> > +    <j:set var="dtd" value="${maven.docbook.dtd}"/>
> > +    <j:if test="${empty(dtd)}">
> > +      <ant:style
> > +        basedir="${maven.docbook.src}"
> > +        destdir="${genDocs}" extension=".xml"
> > +        style="${plugin.resources}/docbook2document.xsl"
> > +        includes="**/*.xml, **/*.sgml"
> > +      />
> > +    </j:if>
> > +    <j:if test="${!empty(dtd)}">
> > +       <echo>Using offline DocBook DTD ${maven.docbook.dtd}</echo>
> > +       <ant:style
> > +        basedir="${maven.docbook.src}"
> > +        destdir="${genDocs}" extension=".xml"
> > +        style="${plugin.resources}/docbook2document.xsl"
> > +        includes="**/*.xml, **/*.sgml">
> > +        <ant:xmlcatalog id="cat">
> > +          <ant:dtd
> > +            publicId="-//OASIS//DTD DocBook XML V4.1.2//EN"
> > +            location="${maven.docbook.dtd}"/>
> > +        </ant:xmlcatalog>
> > +      </ant:style>
> > +    </j:if>
> >    </goal>
> >  </project>
> > Index: xdocs/properties.xml
> > ===================================================================
> > RCS file:
> > /home/cvspublic/maven/src/plugins-build/docbook/xdocs/properties.xml,v
> > retrieving revision 1.1.1.1
> > diff -u -r1.1.1.1 properties.xml
> > --- xdocs/properties.xml   24 Jan 2003 03:45:09 -0000   1.1.1.1
> > +++ xdocs/properties.xml   9 May 2003 13:23:25 -0000
> > @@ -22,6 +22,17 @@
> >              source directory for the simple docbook xml files
> >            </td>
> >          </tr>
> > +        <tr>
> > +          <td>maven.docbook.dtd</td>
> > +          <td>Yes</td>
> > +          <td>
> > +            If set, it points to the offline DocBook DTD.
> > +            This allows offline transformation and DTD checking.
> > +            DocBook DTD is available for download at
> > +            <a
> > href="http://www.oasis-open.org/docbook/xml/4.1.2/index.shtml">http:
> //www.oasis-open.org/docbook/xml/4.1.2/index.shtml</a>.
> > +            Example value: "/home/msk/docbook-dtd/docbookx.dtd"
> > +          </td>
> > +        </tr>
> >        </table>
> >      </section>
> >    </body>
> > --- CUT HERE ---
> -- 
> Martin Skopp
> Riege Software International GmbH
> Support: mailto:maint@riege.com, Information: http://www.riege.com
> 
> This email is intended to be viewed with a nonproportional font.
> Public Key on http://www.keyserver.net, Key-ID: 3D4027B5
> Fingerprint: 1970 C78D 9A1D 99FA 5CE4  5C0D 29E6 6A95 3D40 27B5
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: patch to enable docbook:transform offline, please commit

Posted by Martin Skopp <sk...@riege.de>.
Pretty please could at least someone reply and say why nobody with r/w
access to CVS did the commit?
Thanks,
MSK

On Fri, 2003-05-09 at 15:30, Martin Skopp wrote:
> Hi all commiters,
> 
> I have patched the docbook plugin to allow DTD check against a local
> docbook dtd (for offline processing).
> Localtion of the docbook dtd is specified by new property
> "maven.docbook.dtd"
> 
> Could please someone commit my patch to CVS?
> 
> Thanks in advance,
> Martin
> 
> --- CUT HERE ---
> Index: plugin.jelly
> ===================================================================
> RCS file: /home/cvspublic/maven/src/plugins-build/docbook/plugin.jelly,v
> retrieving revision 1.4
> diff -u -r1.4 plugin.jelly
> --- plugin.jelly	27 Mar 2003 13:14:25 -0000	1.4
> +++ plugin.jelly	9 May 2003 13:23:25 -0000
> @@ -15,13 +15,29 @@
>       
> value="${pom.getPluginContext('maven-xdoc-plugin').getVariable('maven.gen.docs')}"/>
> 
>     
> ${systemScope.setProperty('javax.xml.transform.TransformerFactory','org.apache.xalan.processor.TransformerFactoryImpl')}
> -    <ant:style
> -      basedir="${maven.docbook.src}"
> -      destdir="${genDocs}" extension=".xml"
> -      style="${plugin.resources}/docbook2document.xsl"
> -      includes="**/*.xml, **/*.sgml"
> -    />
> -
> +    <j:set var="dtd" value="${maven.docbook.dtd}"/>
> +    <j:if test="${empty(dtd)}">
> +      <ant:style
> +        basedir="${maven.docbook.src}"
> +        destdir="${genDocs}" extension=".xml"
> +        style="${plugin.resources}/docbook2document.xsl"
> +        includes="**/*.xml, **/*.sgml"
> +      />
> +    </j:if>
> +    <j:if test="${!empty(dtd)}">
> +       <echo>Using offline DocBook DTD ${maven.docbook.dtd}</echo>
> +       <ant:style
> +        basedir="${maven.docbook.src}"
> +        destdir="${genDocs}" extension=".xml"
> +        style="${plugin.resources}/docbook2document.xsl"
> +        includes="**/*.xml, **/*.sgml">
> +        <ant:xmlcatalog id="cat">
> +          <ant:dtd
> +            publicId="-//OASIS//DTD DocBook XML V4.1.2//EN"
> +            location="${maven.docbook.dtd}"/>
> +        </ant:xmlcatalog>
> +      </ant:style>
> +    </j:if>
>    </goal>
>  </project>
> Index: xdocs/properties.xml
> ===================================================================
> RCS file:
> /home/cvspublic/maven/src/plugins-build/docbook/xdocs/properties.xml,v
> retrieving revision 1.1.1.1
> diff -u -r1.1.1.1 properties.xml
> --- xdocs/properties.xml	24 Jan 2003 03:45:09 -0000	1.1.1.1
> +++ xdocs/properties.xml	9 May 2003 13:23:25 -0000
> @@ -22,6 +22,17 @@
>              source directory for the simple docbook xml files
>            </td>
>          </tr>
> +        <tr>
> +          <td>maven.docbook.dtd</td>
> +          <td>Yes</td>
> +          <td>
> +            If set, it points to the offline DocBook DTD.
> +            This allows offline transformation and DTD checking.
> +            DocBook DTD is available for download at
> +            <a
> href="http://www.oasis-open.org/docbook/xml/4.1.2/index.shtml">http://www.oasis-open.org/docbook/xml/4.1.2/index.shtml</a>.
> +            Example value: "/home/msk/docbook-dtd/docbookx.dtd"
> +          </td>
> +        </tr>
>        </table>
>      </section>
>    </body>
> --- CUT HERE ---
-- 
Martin Skopp
Riege Software International GmbH
Support: mailto:maint@riege.com, Information: http://www.riege.com

This email is intended to be viewed with a nonproportional font.
Public Key on http://www.keyserver.net, Key-ID: 3D4027B5
Fingerprint: 1970 C78D 9A1D 99FA 5CE4  5C0D 29E6 6A95 3D40 27B5


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org