You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2016/04/01 02:01:09 UTC

Re: Review Request 44950: Add XFS disk isolator documentation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44950/
-----------------------------------------------------------

(Updated April 1, 2016, 12:01 a.m.)


Review request for mesos, Jie Yu and Jiang Yan Xu.


Changes
-------

Rebased.


Bugs: MESOs-4828
    https://issues.apache.org/jira/browse/MESOs-4828


Repository: mesos


Description
-------

Add XFS disk isolator documentation.


Diffs (updated)
-----

  docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
  docs/mesos-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305 

Diff: https://reviews.apache.org/r/44950/diff/


Testing
-------

Make check. Source inspection.


Thanks,

James Peach

Re: Review Request 44950: Add XFS disk isolator documentation.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44950/#review126932
-----------------------------------------------------------



Patch looks great!

Reviews applied: [44945, 44946, 45689, 44947, 44948, 44949, 44950]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 4, 2016, 5:27 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44950/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 5:27 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOs-4828
>     https://issues.apache.org/jira/browse/MESOs-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add XFS disk isolator documentation.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md da42eaf7069a016fa7eaf929fc285e1fa1f144e9 
>   docs/mesos-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305 
> 
> Diff: https://reviews.apache.org/r/44950/diff/
> 
> 
> Testing
> -------
> 
> Make check. Source inspection.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 44950: Add XFS disk isolator documentation.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44950/#review127270
-----------------------------------------------------------



Patch looks great!

Reviews applied: [44945, 44946, 45689, 44947, 44948, 44949, 44950]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 5, 2016, 11:41 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44950/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 11:41 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOs-4828
>     https://issues.apache.org/jira/browse/MESOs-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add XFS disk isolator documentation.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 309a5a05eab386c8943ba6bdee8d5efeb448aa0c 
>   docs/mesos-containerizer.md 2fde74362f35568bb944da80a1db17e6d3ba9d7b 
>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44950/diff/
> 
> 
> Testing
> -------
> 
> Make check. Source inspection.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 44950: Add XFS disk isolator documentation.

Posted by Jiang Yan Xu <ya...@jxu.me>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44950/#review127563
-----------------------------------------------------------


Fix it, then Ship it!




It's not mentioned in the test summary so could you also verify the formatting in a markdown viewer?

We should follow this up with https://issues.apache.org/jira/browse/MESOS-5140.


docs/configuration.md (line 1746)
<https://reviews.apache.org/r/44950/#comment190936>

    s/range/ranges/



docs/configuration.md (lines 1746 - 1747)
<https://reviews.apache.org/r/44950/#comment190939>

    Also mention "Valid project IDs range from 1 to max(uint32)" before "(default: ...)"



docs/configuration.md (line 1747)
<https://reviews.apache.org/r/44950/#comment190938>

    s/The default is `[5000-10000]`/(default: `[5000-10000]`)/ so it looks the same as the rest of doc.



docs/mesos-containerizer.md (line 94)
<https://reviews.apache.org/r/44950/#comment190940>

    "not be terminated by the containerizer."



docs/mesos-containerizer.md (line 106)
<https://reviews.apache.org/r/44950/#comment190945>

    Mention:
    
    1. The XFS disk isolator is functionally similar to Posix disk isolator but avoids the `du` cost. It's not recommended to use them together, even though they shouldn't interfere with each other.
    2. The XFS disk isolator doesn't natively currently support accounting-only mode like Posix isolator does. (I guess we don't need to mention the `gqnoenforce` option just yet) 
    3. The slave flags mentioned in the "Posix Disk Isolator" section are not applicable to the XFS disk isolator.
    
    Change the wording as you see fit.


- Jiang Yan Xu


On April 6, 2016, 3:36 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44950/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 3:36 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOs-4828
>     https://issues.apache.org/jira/browse/MESOs-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add XFS disk isolator documentation.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 309a5a05eab386c8943ba6bdee8d5efeb448aa0c 
>   docs/mesos-containerizer.md 2fde74362f35568bb944da80a1db17e6d3ba9d7b 
> 
> Diff: https://reviews.apache.org/r/44950/diff/
> 
> 
> Testing
> -------
> 
> Make check. Source inspection.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 44950: Add XFS disk isolator documentation.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44950/#review127510
-----------------------------------------------------------



Bad patch!

Reviews applied: [44950, 44949, 44948, 44947, 45689, 44946, 44945]

Failed command: ./support/apply-review.sh -n -r 45689

Error:
2016-04-06 23:32:22 URL:https://reviews.apache.org/r/45689/diff/raw/ [1413/1413] -> "45689.patch" [1]
error: patch failed: src/tests/cluster.hpp:185
error: src/tests/cluster.hpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12366/console

- Mesos ReviewBot


On April 6, 2016, 10:36 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44950/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 10:36 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOs-4828
>     https://issues.apache.org/jira/browse/MESOs-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add XFS disk isolator documentation.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 309a5a05eab386c8943ba6bdee8d5efeb448aa0c 
>   docs/mesos-containerizer.md 2fde74362f35568bb944da80a1db17e6d3ba9d7b 
> 
> Diff: https://reviews.apache.org/r/44950/diff/
> 
> 
> Testing
> -------
> 
> Make check. Source inspection.
> 
> 
> Thanks,
> 
> James Peach
> 
>