You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Greg Miller (Jira)" <ji...@apache.org> on 2021/05/02 14:44:00 UTC
[jira] [Commented] (LUCENE-9948) Automatically detect multi- vs.
single-valued cases in LongValueFacetCounts
[ https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338038#comment-17338038 ]
Greg Miller commented on LUCENE-9948:
-------------------------------------
I've got a PR almost ready for the implementation changes. I haven't touched the tests yet, but have a couple "nocommit" comments in there with questions around whether-or-not we want to maintain strict backwards-compatibility in some cases. Figure I'll post this early so we can discuss those.
> Automatically detect multi- vs. single-valued cases in LongValueFacetCounts
> ---------------------------------------------------------------------------
>
> Key: LUCENE-9948
> URL: https://issues.apache.org/jira/browse/LUCENE-9948
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Affects Versions: main (9.0)
> Reporter: Greg Miller
> Priority: Minor
>
> The public API in {{LongValueFacetCounts}} currently requires the user to specify whether-or-not a field being counted should be single- or multi-valued (i.e., is it {{NumericDocValues}} or {{SortedNumericDocValues}}). Since we can detect this automatically, it seems unnecessary to ask users to specify. Let's consider updating the implementation to auto-detect these cases and deprecate the ctors that allow explicit specification.
> This is a spin-off issue from LUCENE-9946.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org