You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sangeeta Ravindran <sa...@gmail.com> on 2015/12/23 00:17:47 UTC

Review Request 41666: Typo in error message displayed when connection fails in Hive view

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41666/
-----------------------------------------------------------

Review request for Ambari and Alexandr Antonenko.


Bugs: AMBARI-14442
    https://issues.apache.org/jira/browse/AMBARI-14442


Repository: ambari


Description
-------

There is a typo in the exception message when connection to Hive server fails in Hive view.

H020 Could not establish connecton to...


Diffs
-----

  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Connection.java b64a2a5 
  contrib/views/hive/src/test/java/org/apache/ambari/view/hive/client/ConnectionTest.java bd8dbf9 

Diff: https://reviews.apache.org/r/41666/diff/


Testing
-------

Fix involves updating the string with the typo.

Manual testing and verification.

Added a new test case.


Thanks,

Sangeeta Ravindran


Re: Review Request 41666: Typo in error message displayed when connection fails in Hive view

Posted by Alejandro Fernandez <af...@hortonworks.com>.

> On Dec. 28, 2015, 6:44 p.m., Apache Ambari wrote:
> > Ship It!

I created a service account for "Apache Ambari" and forgot to logout and re-login with my personal account.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41666/#review112031
-----------------------------------------------------------


On Dec. 22, 2015, 11:17 p.m., Sangeeta Ravindran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41666/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 11:17 p.m.)
> 
> 
> Review request for Ambari and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-14442
>     https://issues.apache.org/jira/browse/AMBARI-14442
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There is a typo in the exception message when connection to Hive server fails in Hive view.
> 
> H020 Could not establish connecton to...
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Connection.java b64a2a5 
>   contrib/views/hive/src/test/java/org/apache/ambari/view/hive/client/ConnectionTest.java bd8dbf9 
> 
> Diff: https://reviews.apache.org/r/41666/diff/
> 
> 
> Testing
> -------
> 
> Fix involves updating the string with the typo.
> 
> Manual testing and verification.
> 
> Added a new test case.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>


Re: Review Request 41666: Typo in error message displayed when connection fails in Hive view

Posted by Apache Ambari <ap...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41666/#review112031
-----------------------------------------------------------

Ship it!


Ship It!

- Apache Ambari


On Dec. 22, 2015, 11:17 p.m., Sangeeta Ravindran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41666/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 11:17 p.m.)
> 
> 
> Review request for Ambari and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-14442
>     https://issues.apache.org/jira/browse/AMBARI-14442
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There is a typo in the exception message when connection to Hive server fails in Hive view.
> 
> H020 Could not establish connecton to...
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Connection.java b64a2a5 
>   contrib/views/hive/src/test/java/org/apache/ambari/view/hive/client/ConnectionTest.java bd8dbf9 
> 
> Diff: https://reviews.apache.org/r/41666/diff/
> 
> 
> Testing
> -------
> 
> Fix involves updating the string with the typo.
> 
> Manual testing and verification.
> 
> Added a new test case.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>


Re: Review Request 41666: Typo in error message displayed when connection fails in Hive view

Posted by Sangeeta Ravindran <sa...@gmail.com>.

> On Dec. 22, 2015, 11:34 p.m., Alexandr Antonenko wrote:
> > Ship It!

Thank you. Can you please help push the fix to the right branch.


- Sangeeta


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41666/#review111687
-----------------------------------------------------------


On Dec. 22, 2015, 11:17 p.m., Sangeeta Ravindran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41666/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 11:17 p.m.)
> 
> 
> Review request for Ambari and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-14442
>     https://issues.apache.org/jira/browse/AMBARI-14442
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There is a typo in the exception message when connection to Hive server fails in Hive view.
> 
> H020 Could not establish connecton to...
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Connection.java b64a2a5 
>   contrib/views/hive/src/test/java/org/apache/ambari/view/hive/client/ConnectionTest.java bd8dbf9 
> 
> Diff: https://reviews.apache.org/r/41666/diff/
> 
> 
> Testing
> -------
> 
> Fix involves updating the string with the typo.
> 
> Manual testing and verification.
> 
> Added a new test case.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>


Re: Review Request 41666: Typo in error message displayed when connection fails in Hive view

Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41666/#review111687
-----------------------------------------------------------

Ship it!


Ship It!

- Alexandr Antonenko


On Dec. 22, 2015, 11:17 p.m., Sangeeta Ravindran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41666/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 11:17 p.m.)
> 
> 
> Review request for Ambari and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-14442
>     https://issues.apache.org/jira/browse/AMBARI-14442
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There is a typo in the exception message when connection to Hive server fails in Hive view.
> 
> H020 Could not establish connecton to...
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Connection.java b64a2a5 
>   contrib/views/hive/src/test/java/org/apache/ambari/view/hive/client/ConnectionTest.java bd8dbf9 
> 
> Diff: https://reviews.apache.org/r/41666/diff/
> 
> 
> Testing
> -------
> 
> Fix involves updating the string with the typo.
> 
> Manual testing and verification.
> 
> Added a new test case.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>