[jira] [Commented] (LUCENE-7947) Add interface for point shapes

["Karl Wright (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-7947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148826#comment-16148826 ] 

Karl Wright commented on LUCENE-7947:
-------------------------------------

[~ivera] I'm ok with the interface and the factory, but I'm not happy with the naming.  Are there any better options for the name of the interface?  GeoPoint would obviously be the best choice, but barring that, maybe GeoPointShape?



> Add interface for point shapes
> ------------------------------
>
>                 Key: LUCENE-7947
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7947
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>            Priority: Minor
>         Attachments: LUCENE-7947.patch
>
>
> Hi [~daddywri],
> Just one more thing . 
> One of the shapes I normally use is a point shape. There is not such an interface so what I do currently is to build degenerated circles (circles with radius equal to 0) when I need such a shape. Still looks weird to have GeoCircles when you are dealing with points.
> My proposal is the following:
> 1) Add interface for point shapes which extends GeoCircle and GeoBBox. Not sure which name is appropiate but my take would be to call it GeoLatLonPoint.
> 2) Make GeoDegeneratedPoint implement this interface.
> 3) Add a factory to build GeoLatLonPoint .
> I am adding athe patch shortly.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org