[GitHub] [hive] belugabehr commented on a change in pull request #2339: HIVE-25185: Improve Logging On Polling Tez Session from Pool

[GitBox <gi...@apache.org>]

belugabehr commented on a change in pull request #2339:
URL: https://github.com/apache/hive/pull/2339#discussion_r643585446



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java
##########
@@ -131,13 +131,14 @@ SessionType getSession() throws Exception {
       poolLock.lock();
       try {
         while ((result = pool.poll()) == null) {
-          notEmpty.await(100, TimeUnit.MILLISECONDS);
+          LOG.info("Awaiting Tez session to become available in session pool");
+          notEmpty.await(10, TimeUnit.SECONDS);

Review comment:
       Hello @miklosgergely.  The current change wait for 100ms whereas I have changed this to wait until 10s.  I'm not sure what the value is of setting a timeout, it will always just loop again.  Since I do not see any value here, but I wouldn't want to remove this as part of this ticket, I simply increased it.  Logging once every 100ms would be far too verbose. So you see, this change is logging-related. :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org