[jira] Commented: (HADOOP-2401) Lease holder information should be passed in ClientProtocol.abandonBlock(...)

["dhruba borthakur (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550257 ] 

dhruba borthakur commented on HADOOP-2401:
------------------------------------------

+1 code looks good. I guess it will be difficult to write a unit test for this one, is that right?

> Lease holder information should be passed in ClientProtocol.abandonBlock(...)
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-2401
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2401
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.15.0
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.16.0
>
>         Attachments: 2401_20071210.patch
>
>
> Logically, only the lease holder can do abandonBlock(...).  However, since the file is visible to the other clients once it has been created.  It is possible for the other client to obtain block information for a file which is being created (i.e. not called complete(String, String) yet).  Then, they can do abandonBlock(...) with the obtained block information.
> I suggest to add lease holder information as a parameter in abandonBlock(...). So that we can make sure only the lease holder can do abandonBlock(...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.