[GitHub] [pulsar] jerrypeng commented on a change in pull request #11401: [pulsar-function] Stop calling the deprated method Thread.stop when stopping the function thread in ThreadRuntime.

[GitBox <gi...@apache.org>]

jerrypeng commented on a change in pull request #11401:
URL: https://github.com/apache/pulsar/pull/11401#discussion_r673575520



##########
File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/thread/ThreadRuntime.java
##########
@@ -206,7 +206,7 @@ public void stop() {
                 // kill the thread
                 fnThread.join(THREAD_SHUTDOWN_TIMEOUT_MILLIS, 0);
                 if (fnThread.isAlive()) {
-                    fnThread.stop();
+                    log.warn("The function instance thread is still alive after {} milliseconds, giving up waiting and moving forward.", THREAD_SHUTDOWN_TIMEOUT_MILLIS);

Review comment:
       Nit. Can we change the message to:
   
   "The function instance thread is still alive after {} milliseconds. Giving up waiting and moving forward to close function."




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org