You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2015/11/12 03:53:55 UTC

[GitHub] incubator-zeppelin pull request: Zeppelin-web-docs] angular (beta)...

GitHub user cloverhearts opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/421

    Zeppelin-web-docs] angular (beta) description fix

    Modify the incorrect description of the angular parts of the document unbind.
    
    original
    ```
    // bind my 'object' as angular scope variable 'name' in current notebook.
    z.angularBind(String name, Object object)
    
    // bind my 'object' as angular scope variable 'name' in all notebooks related to current interpreter.
    z.angularBindGlobal(String name, Object object)
    
    // unbind angular scope variable 'name' in current notebook.
    z.angularBind(String name)
    
    // unbind angular scope variable 'name' in all notebooks related to current interpreter.
    z.angularBindGlobal(String name)
    In the example, let's bind "world" variable 'name'. Then you can see AngularJs view are updated immediately.
    ```
    
    fix
    ```
    // bind my 'object' as angular scope variable 'name' in current notebook.
    z.angularBind(String name, Object object)
    
    // bind my 'object' as angular scope variable 'name' in all notebooks related to current interpreter.
    z.angularBindGlobal(String name, Object object)
    
    // unbind angular scope variable 'name' in current notebook.
    z.angularUnbind(String name)
    
    // unbind angular scope variable 'name' in all notebooks related to current interpreter.
    z.angularUnbindGlobal(String name)
    In the example, let's bind "world" variable 'name'. Then you can see AngularJs view are updated immediately.
    
    ```
    
    unbind description 
    **angularBind -> angularUnbind**
    global unbind description
    **angularBindGlobal -> angularUnbindGlobal**


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/incubator-zeppelin modify_docs/angularbinddocs_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/421.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #421
    
----
commit 6dabd02dda02a71fa55d1841269ccc359f022650
Author: Chae-Sung Lim <es...@gmail.com>
Date:   2015-11-12T02:47:45Z

    Zeppelin document ,
    Angular (beta) part : modified unbind context

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web-docs] angular (beta)...

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/421#issuecomment-155984706
  
    Nice find.
    Let's Merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web-docs] angular (beta)...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/421


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web-docs] angular (beta)...

Posted by cloverhearts <gi...@git.apache.org>.

Github user cloverhearts commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/421#issuecomment-155995590
  
    Thank you


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web-docs] angular (beta)...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/421#issuecomment-155995252
  
    LGTM



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---