You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "BrandonArp (via GitHub)" <gi...@apache.org> on 2025/11/06 20:02:07 UTC
[PR] fix(server): Fix overriding of config from env vars [iggy]
BrandonArp opened a new pull request, #2314:
URL: https://github.com/apache/iggy/pull/2314
fix bug where overriding of s3 and file archiver config from environment variables was not working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(server): Fix overriding of config from env vars [iggy]
Posted by "spetz (via GitHub)" <gi...@apache.org>.
spetz commented on PR #2314:
URL: https://github.com/apache/iggy/pull/2314#issuecomment-3502979468
Ok, no need to remove Option<> then, we'll probably need to improve our custom config provider :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(server): Fix overriding of config from env vars [iggy]
Posted by "BrandonArp (via GitHub)" <gi...@apache.org>.
BrandonArp commented on PR #2314:
URL: https://github.com/apache/iggy/pull/2314#issuecomment-3499878999
It does, in fact work after the changes:
Running with
`iggy/core/server$ IGGY_DATA_MAINTENANCE_ARCHIVER_ENABLED=true IGGY_DATA_MAINTENANCE_ARCHIVER_S3_KEY_ID=foo IGGY_DATA_MAINTENANCE_ARCHIVER_S3_BUCKET=foobucket IGGY_DATA_MAINTENANCE_ARCHIVER_S3_ENDPOINT=https://footendpoint IGGY_DATA_MAINTENANCE_ARCHIVER_DISK_PATH=bad/path cargo run`
gives the config
`Using Config: { data_maintenance: { archiver: { enabled: **true**, kind: disk, disk: { path: **bad/path** }, s3: { key_id: **foo**, bucket: **foobucket**, endpoint: **https://fooendpoint.** region: eu-west-1 } }, messages: { archiver_enabled: false, cleaner_enabled: false, interval: 1m }, state: { archiver_enabled: false, overwrite: true, interval: 1m } }, message_saver: { enabled: true, enforce_fsync: true, interval: 30s }, heartbeat: { enabled: false, interval: 5s }, system: { path: local_data, logging: { path: logs, level: info, max_size: 512.00 MB, retention: 7days }, stream: { path: streams }, topic: { path: topics, max_size: unlimited, delete_oldest_segments: false }, partition: { path: partitions, messages_required_to_save: 1024, size_of_messages_required_to_save: 1.05 MB, enforce_fsync: false, validate_checksum: false }, segment: { size_bytes: 1.07 GB, cache_indexes: OpenSegment, message_expiry: never_expire, archive_expired: false, server_confirmation: wait }, encryption
: { enabled: false }, state: { enforce_fsync: false, max_file_operation_retries: 1, retry_delay: 1s } }, quic: { enabled: true, address: 127.0.0.1:8080, max_concurrent_bidi_streams: 10000, datagram_send_buffer_size: 100.00 KB, initial_mtu: 8.00 KB, send_window: 100.00 KB, receive_window: 100.00 KB, keep_alive_interval: 5s, max_idle_timeout: 10s, certificate: { self_signed: true, cert_file: core/certs/iggy_cert.pem, key_file: core/certs/iggy_key.pem } }, tcp: { enabled: true, address: 127.0.0.1:8090, ipv6: false, tls: { enabled: false, cert_file: core/certs/iggy_cert.pem, key_file: core/certs/iggy_key.pem }, socket: { override defaults: false, recv buffer size: 100.00 KB, send buffer size 100.00 KB, keepalive: false, nodelay: false, linger: 0s } }, http: { enabled: true, address: 127.0.0.1:3000, max_request_size: 2.00 MB, cors: { enabled: true, allowed_methods: ["GET", "POST", "PUT", "DELETE"], allowed_origins: ["*"], allowed_headers: ["content-type"], exposed_headers: [""], allow_cr
edentials: false, allow_private_network: false }, jwt: { algorithm: HS256, audience: iggy.apache.org, access_token_expiry: 1h, use_base64_secret: false }, metrics: { enabled: true, endpoint: /metrics }, tls: { enabled: false, cert_file: core/certs/iggy_cert.pem, key_file: core/certs/iggy_key.pem } }, telemetry: { enabled: false, service_name: iggy, logs: { transport: grpc, endpoint: http://localhost:7281/v1/logs }, traces: { transport: grpc, endpoint: http://localhost:7281/v1/traces } } }`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(server): Fix overriding of config from env vars [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio merged PR #2314:
URL: https://github.com/apache/iggy/pull/2314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(server): Fix overriding of config from env vars [iggy]
Posted by "spetz (via GitHub)" <gi...@apache.org>.
spetz commented on PR #2314:
URL: https://github.com/apache/iggy/pull/2314#issuecomment-3499394197
Thanks for the contribution! Were you able to validate whether providing the default values allows the env override, or should we remove the Option<> from these fields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org