You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2015/02/04 16:37:25 UTC
Review Request 30617: Cover Stack Versions page with unit tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30617/
-----------------------------------------------------------
Review request for Ambari and Andriy Babiichuk.
Bugs: AMBARI-9470
https://issues.apache.org/jira/browse/AMBARI-9470
Repository: ambari
Description
-------
Cover Stack Versions page with unit tests.
Change the filter label to "Upgrade/Downgrade In Process".
Diffs
-----
ambari-web/app/assets/test/tests.js d2cf0e7
ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 55ac9c3
ambari-web/app/messages.js 9fba91c
ambari-web/app/views/main/admin/stack_upgrade/services_view.js c2fd7fb
ambari-web/app/views/main/admin/stack_upgrade/upgrade_task_view.js 467e72c
ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js 9227965
ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js ea3c203
ambari-web/app/views/main/admin/stack_upgrade/versions_view.js c385e34
ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js f47219c
ambari-web/test/views/main/admin/stack_upgrade/services_view_test.js PRE-CREATION
ambari-web/test/views/main/admin/stack_upgrade/upgrade_task_view_test.js ca1d8ba
ambari-web/test/views/main/admin/stack_upgrade/upgrade_version_box_view_test.js 69134bb
ambari-web/test/views/main/admin/stack_upgrade/upgrade_wizard_view_test.js f6cdc11
ambari-web/test/views/main/admin/stack_upgrade/version_view_test.js 83d69ee
Diff: https://reviews.apache.org/r/30617/diff/
Testing
-------
5390 tests complete (9 seconds)
63 tests pending
Thanks,
Andrii Tkach
Re: Review Request 30617: Cover Stack Versions page with unit tests
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30617/#review71015
-----------------------------------------------------------
ambari-web/app/messages.js
<https://reviews.apache.org/r/30617/#comment116526>
Can this be detected?
- Alejandro Fernandez
On Feb. 4, 2015, 3:37 p.m., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30617/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 3:37 p.m.)
>
>
> Review request for Ambari and Andriy Babiichuk.
>
>
> Bugs: AMBARI-9470
> https://issues.apache.org/jira/browse/AMBARI-9470
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Cover Stack Versions page with unit tests.
> Change the filter label to "Upgrade/Downgrade In Process".
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js d2cf0e7
> ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 55ac9c3
> ambari-web/app/messages.js 9fba91c
> ambari-web/app/views/main/admin/stack_upgrade/services_view.js c2fd7fb
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_task_view.js 467e72c
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js 9227965
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js ea3c203
> ambari-web/app/views/main/admin/stack_upgrade/versions_view.js c385e34
> ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js f47219c
> ambari-web/test/views/main/admin/stack_upgrade/services_view_test.js PRE-CREATION
> ambari-web/test/views/main/admin/stack_upgrade/upgrade_task_view_test.js ca1d8ba
> ambari-web/test/views/main/admin/stack_upgrade/upgrade_version_box_view_test.js 69134bb
> ambari-web/test/views/main/admin/stack_upgrade/upgrade_wizard_view_test.js f6cdc11
> ambari-web/test/views/main/admin/stack_upgrade/version_view_test.js 83d69ee
>
> Diff: https://reviews.apache.org/r/30617/diff/
>
>
> Testing
> -------
>
> 5390 tests complete (9 seconds)
> 63 tests pending
>
>
> Thanks,
>
> Andrii Tkach
>
>
Re: Review Request 30617: Cover Stack Versions page with unit tests
Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30617/#review70967
-----------------------------------------------------------
Ship it!
Ship It!
- Andriy Babiichuk
On Фев. 4, 2015, 3:37 п.п., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30617/
> -----------------------------------------------------------
>
> (Updated Фев. 4, 2015, 3:37 п.п.)
>
>
> Review request for Ambari and Andriy Babiichuk.
>
>
> Bugs: AMBARI-9470
> https://issues.apache.org/jira/browse/AMBARI-9470
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Cover Stack Versions page with unit tests.
> Change the filter label to "Upgrade/Downgrade In Process".
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js d2cf0e7
> ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 55ac9c3
> ambari-web/app/messages.js 9fba91c
> ambari-web/app/views/main/admin/stack_upgrade/services_view.js c2fd7fb
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_task_view.js 467e72c
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js 9227965
> ambari-web/app/views/main/admin/stack_upgrade/upgrade_wizard_view.js ea3c203
> ambari-web/app/views/main/admin/stack_upgrade/versions_view.js c385e34
> ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js f47219c
> ambari-web/test/views/main/admin/stack_upgrade/services_view_test.js PRE-CREATION
> ambari-web/test/views/main/admin/stack_upgrade/upgrade_task_view_test.js ca1d8ba
> ambari-web/test/views/main/admin/stack_upgrade/upgrade_version_box_view_test.js 69134bb
> ambari-web/test/views/main/admin/stack_upgrade/upgrade_wizard_view_test.js f6cdc11
> ambari-web/test/views/main/admin/stack_upgrade/version_view_test.js 83d69ee
>
> Diff: https://reviews.apache.org/r/30617/diff/
>
>
> Testing
> -------
>
> 5390 tests complete (9 seconds)
> 63 tests pending
>
>
> Thanks,
>
> Andrii Tkach
>
>